Skip to content

Make rmm build and link on Windows #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeffdaily wants to merge 1 commit into
base: release/rocmds-26.03
Choose a base branch
from
Open

Make rmm build and link on Windows #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,12 @@ set_target_properties(
CXX_STANDARD_REQUIRED ON
CXX_VISIBILITY_PRESET hidden
POSITION_INDEPENDENT_CODE ON
INTERFACE_POSITION_INDEPENDENT_CODE ON)
INTERFACE_POSITION_INDEPENDENT_CODE ON
# RMM_EXPORT is an ELF visibility attribute under __GNUC__ and empty
# otherwise, so a Windows build of this shared library exports nothing
# and every consumer fails to link. Let CMake generate the export
# table there; the property is ignored on other platforms.
WINDOWS_EXPORT_ALL_SYMBOLS ON)
target_compile_definitions(rmm PUBLIC LIBCUDACXX_ENABLE_EXPERIMENTAL_MEMORY_RESOURCE)

# Enable NVTX if necessary
Expand Down
1 change: 0 additions & 1 deletion cpp/include/rmm/detail/runtime_capabilities.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@

#include <rmm/cuda_runtime_api.h>

#include <dlfcn.h>

namespace RMM_NAMESPACE {
namespace detail {
Expand Down