Modernize Frogram interface - #8
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6cb41fd14f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| FillingDrawable drawable = new FillingDrawable(ColorId.overlayFilling, FrogramUi.POPUP_RADIUS); | ||
| drawable.setForcedTheme(forcedTheme); | ||
| ViewUtils.setBackground(this, drawable); |
There was a problem hiding this comment.
Preserve the overflow-menu shadow
Replacing bg_popup_fixed with FillingDrawable removes the nine-patch's baked-in shadow. The subsequent elevation does not restore it because FillingDrawable does not provide a nonzero outline for elevation shadows, and Android 16–20 (which this project supports) cannot use elevation at all. As a result, overflow menus render without any shadow across supported versions; retain a shadow-bearing drawable, implement an outline for API 21+, and keep a legacy fallback.
Useful? React with 👍 / 👎.
Restore the interface and Green theme to the state before PR #8 while preserving all earlier Frogram features and fixes.
Что изменено
FrogramUi, чтобы дальше развивать дизайн последовательно.Иконки и существующая система тем не заменялись. Бизнес-логика топиков и двойного дна не затрагивалась.
Проверка
git diff --check— успешно;