Skip to content

fix(helm): apiserverExternalEgress list + serverName comment + doc (v0.2.3)#7

Merged
cadolbeau-absyss merged 3 commits into
mainfrom
fix/apiserverExternalEgress-list-and-doc-fixes
May 29, 2026
Merged

fix(helm): apiserverExternalEgress list + serverName comment + doc (v0.2.3)#7
cadolbeau-absyss merged 3 commits into
mainfrom
fix/apiserverExternalEgress-list-and-doc-fixes

Conversation

@Cadolbeau

Copy link
Copy Markdown
Contributor

Summary

  • Fix apiserverExternalEgress: was a single object (port/cidr), now a list — allows defining multiple egress NetworkPolicy rules from vtom-apiserver to external endpoints (e.g. MFT on a remote cluster). The old structure was silently ignored when empty.
  • Clarify serverName comment: the value is the name sent to agents so they can report job execution status back to the server. It must point to the vtom-server LoadBalancer hostname (or IP). The default K8s service name vtom-server is unreachable by external agents.
  • Add MetalLB prerequisite in on-premise prerequisites section (README EN + FR): type: LoadBalancer Services remain in <pending> indefinitely without a LoadBalancer implementation on bare-metal clusters.

Test plan

  • helm lint passes on all cloud profiles (azure, aws, gcp, onpremise)
  • helm template with apiserverExternalEgress: [] generates no NetworkPolicy for apiserver external egress
  • helm template with one or more entries in apiserverExternalEgress generates one egress rule per entry

🤖 Generated with Claude Code

cadolbeau-absyss and others added 3 commits May 29, 2026 14:08
…0.2.3)

- Fix apiserverExternalEgress: was a single object, now a list — allows
  defining multiple egress NetworkPolicy rules from vtom-apiserver to
  external endpoints (e.g. MFT on a remote cluster)
- Clarify serverName comment: name sent to agents to report job status
  back to the server; must point to the vtom-server LoadBalancer hostname
  (K8s service name unreachable by external agents)
- Add MetalLB prerequisite note in on-premise prerequisites (README EN + FR)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
READMEs belong at the repo root (already there on main), not duplicated
inside the chart directory.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
serverName must be a simple hostname (no dots). Adding DomainName in
vtom.ini makes VTOM send "<serverName>.<DomainName>" to agents.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@cadolbeau-absyss cadolbeau-absyss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@cadolbeau-absyss cadolbeau-absyss merged commit adb8657 into main May 29, 2026
4 checks passed
@cadolbeau-absyss cadolbeau-absyss deleted the fix/apiserverExternalEgress-list-and-doc-fixes branch May 29, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants