testing: Additional ref output for render-microfacet for Mac ARM + cpp - #2139
Merged
Conversation
Signed-off-by: Larry Gritz <lg@larrygritz.com>
Collaborator
Author
|
I'm planning to merge this immediately after it fully passes CI, since it fixes what's breaking every other PR's CI. |
lgritz
merged commit Jul 29, 2026
2e92762
into
AcademySoftwareFoundation:main
48 of 49 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know, something must have changed on the GHA runner that once again slightly changed the output for this one test, only on one platform, only when testing the new C++ debugging output. Visually, it's fine, just slightly changed sampling firefly locations in a small number of pixels. It's equally "right", just different. The expedient fix is to check in an additional reference image to let it pass.