Skip to content

fix: browser and console#2064

Open
RohitKushvaha01 wants to merge 2 commits intoAcode-Foundation:mainfrom
RohitKushvaha01:fix_console
Open

fix: browser and console#2064
RohitKushvaha01 wants to merge 2 commits intoAcode-Foundation:mainfrom
RohitKushvaha01:fix_console

Conversation

@RohitKushvaha01
Copy link
Copy Markdown
Member

No description provided.

@RohitKushvaha01 RohitKushvaha01 marked this pull request as draft April 27, 2026 09:05
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 27, 2026

Greptile Summary

This PR adds edge-to-edge layout support for the BrowserActivity on API 30+, calling setDecorFitsSystemWindows(false) and applying an OnApplyWindowInsetsListener to pad the browser view to account for system bars. The insets block is correctly gated behind Build.VERSION.SDK_INT >= 30, addressing the unconditional listener concern raised in prior review threads; the remaining open items (deprecated inset accessor methods and import ordering) were flagged in earlier rounds.

Confidence Score: 5/5

Safe to merge; no new P1/P0 issues introduced — remaining concerns (deprecated accessor methods, import ordering) were already flagged in prior review threads.

The only changed file introduces a correctly API-gated edge-to-edge block. The unconditional listener issue from earlier threads has been resolved by placing the block inside if (Build.VERSION.SDK_INT >= 30). Remaining findings are P2 style/deprecation items carried from prior rounds.

No files require special attention.

Important Files Changed

Filename Overview
src/plugins/browser/android/com/foxdebug/browser/BrowserActivity.java Adds edge-to-edge insets handling gated on API >= 30; uses deprecated getSystemWindowInset* / consumeSystemWindowInsets() accessors (flagged in prior review threads); import ordering nit also previously flagged.

Sequence Diagram

sequenceDiagram
    participant OS as Android OS (API 30+)
    participant DA as BrowserActivity.onCreate()
    participant W as Window
    participant B as Browser (View)

    DA->>W: setDecorFitsSystemWindows(false)
    Note over W: Window layouts behind system bars
    DA->>B: setOnApplyWindowInsetsListener(...)
    Note over DA: Listener registered only for API >= 30
    DA->>DA: setSystemTheme(primaryColor)

    OS-->>B: onApplyWindowInsets(insets)
    B->>B: setPadding(left, top, right, bottom)
    B-->>OS: consumeSystemWindowInsets()
    Note over B: Content inset from system bars via padding
Loading

Reviews (3): Last reviewed commit: "fix: browser" | Re-trigger Greptile

Comment thread src/plugins/browser/android/com/foxdebug/browser/BrowserActivity.java Outdated
Comment thread src/plugins/browser/android/com/foxdebug/browser/BrowserActivity.java Outdated
@RohitKushvaha01
Copy link
Copy Markdown
Member Author

@greptileai

@RohitKushvaha01 RohitKushvaha01 marked this pull request as ready for review April 27, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant