Enforce tenant isolation via TenantScopedClient + CI guard - #5
Open
AshSgDe29071999 wants to merge 3 commits into
Open
Enforce tenant isolation via TenantScopedClient + CI guard#5AshSgDe29071999 wants to merge 3 commits into
AshSgDe29071999 wants to merge 3 commits into
Conversation
Isolation used to rest on every call site remembering build_filter. Route all search reads through a wrapper that requires tenant_id and always injects the tenant filter (including hybrid Prefetch branches). A CI test fails if package code calls client.query_points/scroll/retrieve outside that wrapper. search() behaviour is unchanged for callers. Fixes AgentPostmortem#3
Author
|
Fixed ruff I001/F401 in tests (import sorting + unused |
Author
|
Fixed remaining CI ruff I001: first-party imports in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tenant isolation depended on every query path calling
build_filter. A forgotten filter is silent and returns other tenants' documents.TenantScopedClient— requiredtenant_id, always injects tenant filtersearch()uses the wrapper for dense/sparse/hybrid (incl. Prefetch)client.query_points/scroll/retrieveoutside the wrappersearch()results unchanged for normal callers.Test plan
pytest(incl. multitenancy + new scoped access tests)client.query_pointspattern matches the guardFixes #3