fix: reject empty/whitespace tenant_id at the filter boundary - #6
Open
AshSgDe29071999 wants to merge 1 commit into
Open
fix: reject empty/whitespace tenant_id at the filter boundary#6AshSgDe29071999 wants to merge 1 commit into
AshSgDe29071999 wants to merge 1 commit into
Conversation
Empty tenant_id previously became MatchValue("") and returned no
hits, which looks like "this tenant has no documents" instead of
"request was not scoped". Raise UnscopedTenantError with a clear
message; allow tenant ids that merely contain spaces.
Fixes AgentPostmortem#4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Empty or whitespace-only
tenant_idvalues were turned intoMatchValue(""), so searches returned zero hits and looked like an empty tenant rather than a missing scope.Changes
require_tenant_id()+UnscopedTenantErroratbuild_filter/search"", whitespace, and a valid id containing spacesNote: this repo has no HTTP API in
app.py(container entrypoint only). The library/CLI boundary raisesUnscopedTenantError(subclass ofValueError); an HTTP layer would map that to 4xx.Test plan
tests/test_search.pyFixes #4