test(utils): cover hashIp and getClientIp - #65
Merged
Conversation
|
Merged. Thanks a lot, @waterlemonnn. Genuinely helpful change for agentpostmortem. If this project helps you out, a star helps others find it too. Happy to see more from you whenever you have the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
lib/utils/hash.test.ts, covering the two functions inlib/utils/hash.tsthat had no test coverage.hashIp()throws whenIP_HASH_PEPPERis unsethashIp()is deterministic for a given input/pepper pair, and differs across peppershashIp()trims surrounding whitespace before hashinggetClientIp()takes the first entry of a comma-separatedx-forwarded-forgetClientIp()falls back tox-real-ip, then to"unknown"Closes #26.
Test plan
npx vitest run lib/utils/hash.test.ts— 7/7 passingnpx vitest run— full suite, 94/94 passingnpm run lint— cleannpx tsc --noEmit— clean