test(search): cover short-query early return and result path - #79
Open
waterlemonnn wants to merge 1 commit into
Open
test(search): cover short-query early return and result path#79waterlemonnn wants to merge 1 commit into
waterlemonnn wants to merge 1 commit into
Conversation
Newsletter route already has coverage from AgentPostmortem#68 (new/existing/ reactivated subscriber cases). This adds the missing search half: queries under 2 chars short-circuit without hitting the DB, and a normal query passes agent/severity filters through to fetchSearchPosts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63.
Newsletter already has `route.test.ts` covering the new/existing/reactivated-subscriber branching (landed in #68), so the remaining gap from this issue was the search route. Added `app/api/search/route.test.ts`:
{ posts: [] }without callingfetchSearchPosts(also checked the no-query case)fetchSearchPostswith the trimmed query and returns its resultTest plan
npx vitest run— 112/112 passnpx eslint app/api/search/route.test.ts— cleannpx tsc --noEmit— clean