fix: resolve #800 — broker: composable wait-conditions for CLI readiness (steal from ht)

[SlncTrZ]

Summary

fix: resolve #800 — broker: composable wait-conditions for CLI readiness (steal from ht)

Problem

Severity: Low | File: src/wait.rs (additional implementation for VT cursor - deferred)

Add a placeholder for the Cursor variant of WaitCondition to signal that it will be implemented once the VT100 grid (#3) is available. This ensures the API is future‑proof without breaking current code.

Solution

Extend the WaitCondition enum in src/wait.rs with:

Changes

• src/wait.rs (new)

Testing

• Existing tests pass
• Manual review completed
• No new warnings/errors introduced"

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5832efdf-65a6-4236-8455-5a618e78acc7

📥 Commits

Reviewing files that changed from the base of the PR and between bffd6b2 and a8a3e0b.

📒 Files selected for processing (1)

• src/wait.rs

---

📝 Walkthrough

Walkthrough

A new public WaitCondition enum is introduced in src/wait.rs with a Cursor variant to support composable wait conditions for CLI readiness detection, establishing the foundational type for the wait condition taxonomy.

Changes

Wait Condition Type

Layer / File(s)	Summary
Public Type Definition src/wait.rs	Introduces WaitCondition enum with Cursor variant as the initial wait condition type.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A new enum hops into view,
Cursor waits for CLIs to be true,
One variant born, more shall follow,
Building blocks for paths we'll swallow,
Composability blooms anew!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Linked Issues check	❓ Inconclusive	The PR adds only a placeholder Cursor variant and omits the other core wait conditions (Text, Idle, Change, Exit) required by issue #800.	Clarify whether this is intentionally a partial implementation or if the remaining conditions should be included. Consider whether the stub-only approach aligns with the linked issue's expectations.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly references issue #800 and describes the main change: adding a composable wait-conditions enum with placeholder Cursor variant.
Description check	✅ Passed	The description includes Problem/Solution/Changes sections and a testing checklist matching the template structure, though some details like test status are left unchecked.
Out of Scope Changes check	✅ Passed	All changes in the PR are scoped to the new WaitCondition enum stub; no extraneous modifications are present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[devin-ai-integration]

Devin Review found 1 potential issue.

View 1 additional finding in Devin Review.

[devin-ai-integration]

🟡 New module wait is never declared, making it dead/unreachable code

The new file src/wait.rs defines pub enum WaitCondition, but neither src/lib.rs nor src/main.rs contains a mod wait; declaration. In Rust, a .rs file that isn't referenced by any mod declaration is completely ignored by the compiler — it is never compiled and its types are inaccessible. This means the entire purpose of this PR (adding composable wait-conditions) is unfulfilled: no other module can import or use WaitCondition. Every other module in the crate has a corresponding mod declaration in src/lib.rs:1-23 or src/main.rs:9-19.

Prompt for agents

The file src/wait.rs is added but no mod wait; declaration exists in either src/lib.rs or src/main.rs. In this Rust crate, lib.rs declares public modules (like pub mod auth, pub mod config, etc.) and main.rs declares private implementation modules (like mod broker, mod helpers, etc.). Depending on whether WaitCondition should be part of the public library API or only used internally by the binary, add either pub mod wait; to src/lib.rs or mod wait; to src/main.rs.

---

Was this helpful? React with 👍 or 👎 to provide feedback.