Skip to content

docs(writing-agent-relay-workflows): pr_url verification + github-primitive PR contract#40

Open
khaliqgant wants to merge 1 commit into
mainfrom
feat/pr-url-verification-guidance
Open

docs(writing-agent-relay-workflows): pr_url verification + github-primitive PR contract#40
khaliqgant wants to merge 1 commit into
mainfrom
feat/pr-url-verification-guidance

Conversation

@khaliqgant
Copy link
Copy Markdown
Member

Summary

Documents the new `verification: { type: 'pr_url', value: 'owner/repo' }` check (landing in `@agent-relay/workflow-types` via relay#852) and pairs it with the existing `createGitHubStep({ action: 'createPR' })` guidance so the worker always publishes the PR through the github-primitive — not raw `gh pr create` — and the verifier refuses to mark the step complete when no GitHub PR URL appears in the output.

Motivation

The proactive-runtime M3 swarm shipped six Track A–F implementation steps. Every worker posted `OWNER_DECISION: COMPLETE` with green tests and a clean process exit, and every worker forgot to actually open a pull request. The runner's evidence-based completion path accepted that — file mods + positive-conclusion text + exit 0 was enough. `pr_url` closes that loophole declaratively; pairing it with `createGitHubStep` ensures the worker uses the same primitive whether it runs locally (gh CLI) or in cloud (Nango), and that its output naturally contains a URL the verifier can find.

Changes

  • Add `pr_url` to the verification-gates code block
  • Cross-link to the existing "Shipping the Result — Open a PR via `createGitHubStep`" section
  • Spell out that workers should never shell out to raw `gh pr create` when `createGitHubStep` is available

🤖 Generated with Claude Code

…ithub-primitive PR contract

Recommends pairing `verification: { type: 'pr_url', value: 'owner/repo' }`
(landing in @agent-relay/workflow-types via relay#852) with
`createGitHubStep({ action: 'createPR' })` so the worker opens the PR
through the github-primitive — not raw `gh pr create` — and the verifier
catches a missing PR before the step completes.

Closes the failure mode where proactive-runtime M3 workers reported
OWNER_DECISION: COMPLETE with green tests but no PR open on any branch.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Warning

Rate limit exceeded

@khaliqgant has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minute and 12 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bb07e717-842d-431d-b736-2484842bb3ad

📥 Commits

Reviewing files that changed from the base of the PR and between 2296765 and 441c9b4.

📒 Files selected for processing (1)
  • skills/writing-agent-relay-workflows/SKILL.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/pr-url-verification-guidance

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant