Skip to content

feat(persona-kit): drop traits + sandbox (Track D)#103

Draft
khaliqgant wants to merge 3 commits into
mainfrom
feat/persona-kit-drop-traits-and-sandbox
Draft

feat(persona-kit): drop traits + sandbox (Track D)#103
khaliqgant wants to merge 3 commits into
mainfrom
feat/persona-kit-drop-traits-and-sandbox

Conversation

@khaliqgant
Copy link
Copy Markdown
Member

Summary

Implements Track D from the schema-cascade spec (docs/plans/deploy-v1-schema-cascade-spec.md, §496–557). The previous cascade run mistakenly marked Track-D as MERGE_READY=1 because its original target branch (refactor/persona-kit-schema-lockin) had no commits ahead of main and workforce#95 covered a different concept (tiers flatten, not traits/sandbox). This PR is the missing Track-D work.

  • Remove the persona-level traits field + PersonaTraits type + parseTraits / re-exports.
  • Remove the persona-level sandbox field + PersonaSandbox / PersonaSandboxConfig types + parseSandbox / re-exports. The codex-level harnessSettings.sandboxMode, workspaceWriteNetworkAccess, and dangerouslyBypassApprovalsAndSandbox are untouched — those are the harness sandbox flag, separate from this concept.
  • Parser now rejects either key with the spec-mandated v1 migration error pointing at docs/plans/deploy-v1.md.
  • Add JSDoc on PersonaSpec / PersonaSchedule / PersonaIntegrationConfig framing them as the clock + radio listener parts of a persona's listener surface (inbox reserved for later).
  • Strip sandbox: true from examples/weekly-digest/persona.json.
  • Rewrite docs/plans/deploy-v1.md §3 narrative — drop traits/sandbox rows from the additions table, repurpose §3.4 into "Sandbox (deploy-time, not persona-level)", and §3.6 into "Traits (removed in v1)".
  • Update the deploy sandbox launcher to stop reading per-persona sandbox.timeoutSeconds (the sandbox-client default ~600s applies; harness-level timeouts continue to live on harnessSettings.timeoutSeconds).

Acceptance bullets (spec §547)

  • traits and sandbox types removed from persona-kit types.ts and parse.ts.
  • Parser rejects traits and sandbox with the spec-specified errors (covered by two new tests in parse.test.ts).
  • All persona fixtures + 15 core personas (including proactive-agent-builder) parse without errors — personas-core lint is green.
  • Listeners JSDoc + deploy-v1.md §3 narrative updated.
  • Persona JSON schema regen: emit-schema.mjs does not exist on this branch — flagged for workforce#94 to pick up on rebase, per spec step 4.
  • corepack pnpm -r run build && corepack pnpm run typecheck && corepack pnpm -r run test all green (376 tests pass across 7 packages).
  • PR opens as DRAFT.

Test plan

  • corepack pnpm -r run build — green.
  • corepack pnpm run typecheck (incl. typecheck:examples) — green.
  • corepack pnpm -r run test — 376/376 tests pass.
  • corepack pnpm -r --filter @agentworkforce/personas-core run lint — 15 personas validate.
  • New parse.test.ts cases assert the exact spec error wording for traits and sandbox rejection.

Downstream

Unblocks the workforce sweep that was stalled on Track-D=SKIPPED:

Each will need a rebase against this branch's main commit once it merges; expect mechanical conflicts in packages/persona-kit/src/parse.ts / types.ts for branches that touched the same blocks.

🤖 Generated with Claude Code

Ricky Schema Cascade and others added 3 commits May 13, 2026 09:32
Remove the persona-level `traits` and `sandbox` (workforce-orchestration)
fields from PersonaSpec, along with their parser logic and exports. The
parser now rejects either key with the v1 migration error pointing
authors at deploy-v1.md. Codex-level `harnessSettings.sandboxMode` /
`workspaceWriteNetworkAccess` / `dangerouslyBypassApprovalsAndSandbox`
stay — they are the harness sandbox flag, separate from this concept.

Add JSDoc on PersonaSpec / PersonaSchedule / PersonaIntegrationConfig
framing them as the clock + radio listener parts of a persona's listener
surface. Inbox (RelayCast targeted messages) is reserved for a later
iteration.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…consumers

- runtime: stop re-exporting PersonaTraits; trim WorkforceCtx.persona JSDoc.
- deploy/sandbox launcher: drop reliance on `persona.sandbox.timeoutSeconds`
  for the runner exec envelope. Per-persona sandbox tuning was removed in
  v1; the sandbox-client default (~600s) applies. Harness-level timeouts
  continue to live on `harnessSettings.timeoutSeconds`.
- examples/weekly-digest/persona.json: remove the `sandbox: true` block so
  the fixture parses post-Track-D (sandbox is on by default at deploy time).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…sandbox

Section 3 (Persona JSON schema diff) now opens with the listeners
narrative — clock (schedules), radio (integration triggers), inbox
(reserved). The top-level additions table drops `sandbox` and `traits`.

§3.4 is repurposed to "Sandbox (deploy-time, not persona-level)" calling
out --no-sandbox as the opt-out, and §3.6 is replaced with a Traits
(removed in v1) explainer pointing at the future
persona-personality-builder tool.

Bullet list / fixture-checklist references also stripped.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3903506d-2547-4e3e-9e25-490def6a1fc9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/persona-kit-drop-traits-and-sandbox

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant