[codex] Improve quality gates and coverage - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
This PR addresses the recent uncommitted quality cleanup work and prepares it for review after local verification. The requested outcome was to review the changes, confirm they are correct, push the code, and open a PR with the right project knowledge captured for reviewers.
Context / Project Knowledge
AGENTS.mdrequires scoped source changes, preservation of user work, and relevant gate execution before handoff.make check, which runs Ruff linting, Ruff format check, mypy, pytest, and the golden-principles repository check.bd) is the project issue workflow, but the local git hooks skipped bead sync becausebdis not installed on this PATH.Changes
BasicAgent, context-engineering primitives, search orchestration, and specialized-agent helper behavior.docs/QUALITY_SCORE.mdwith current evidence for tests, typing, documentation, and remaining coverage gaps.types-requeststo the dev dependency set and lockfile for cleaner type checking.Verification
Ran the full local quality gate before committing:
PATH="$HOME/.local/bin:/opt/homebrew/bin:$PATH" make checkResults:
uv run ruff check agentic_internet tests: passeduv run ruff format --check agentic_internet tests: passed, 45 files already formatteduv run mypy agentic_internet: passed, 29 source filesuv run pytest: 184 passed, 4 Pydantic deprecation warningspython3 .opencode/tools/golden_principles.py: passedAdditional review checks run before push:
git diff --check: passedpytest --cov=agentic_internet --cov-report=term-missing: 184 passed, total coverage 48%Known Follow-Up
multi_model_serpapi.pyremains large and under-covered at 33% coverage.bdshould be installed or added to PATH so git hooks can sync beads during future commits and pushes.