Skip to content

Added definition for bag#975

Open
kbennett2000 wants to merge 1 commit intomainfrom
kbennett2000-patch-3
Open

Added definition for bag#975
kbennett2000 wants to merge 1 commit intomainfrom
kbennett2000-patch-3

Conversation

@kbennett2000
Copy link
Copy Markdown
Contributor

  • Added definition for bag and described differences between bags and sets

- Added definition for `bag` and described differences between bags and sets
@kbennett2000 kbennett2000 requested a review from dckc February 14, 2024 16:29
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6b94d52
Status: ✅  Deploy successful!
Preview URL: https://08e5f988.documentation-7tp.pages.dev
Branch Preview URL: https://kbennett2000-patch-3.documentation-7tp.pages.dev

View logs

Copy link
Copy Markdown
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is different from what I had in mind; when looking for suggestions, I found even more existing problems. I'm not sure how many of them to bite off just now.

Comment thread main/glossary/README.md
[Purses](#purse) and [payments](#payment) are AssetHolders. These are objects that contain
digital assets in the quantity specified by an [amount](#amount).

## Bag
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I had in mind was not defining the general concept of Bag, but making a link between discussion of semi-fungible (e.g. in the glossary entry) and the discussion of AssetKind.COPY_BAG. Looks like the latter is in /reference/ertp-api/ertp-data-types.html#assetkind

Ugh... It looks like "AmountValues are arrays of objects." got copied from the AssetKind.COPY_SET bullet to the AssetKind.COPY_BAG bullet, where it doesn't apply.

There's some good docs in the source code:

https://github.com/Agoric/agoric-sdk/blob/23a970d49d44d3ec3159a5f402efb81bb3aff269/packages/ERTP/src/typeGuards.js#L48-L65

Here's hoping for time to talk about how to meld that with the docs site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants