fix(en.aquamanga): full source rebuild for aquareader.org - #666
Open
z3niith wants to merge 11 commits into
Open
Conversation
Co-authored-by: kantan <31490942+kkantan@users.noreply.github.com>
z3niith
marked this pull request as ready for review
August 2, 2026 22:25
kkantan
requested changes
Aug 3, 2026
Comment on lines
+202
to
+203
| page_str = page.to_string(); | ||
| let _ = &page_str; |
Contributor
Author
There was a problem hiding this comment.
a workaround used to suppress an unused variable warning, though it can be removed and replaced with
page_str
Comment on lines
+165
to
+184
| if has_search { | ||
| let mut qs = QueryParameters::new(); | ||
| qs.push("s", Some(&query_str)); | ||
| qs.push("post_type", Some("wp-manga")); | ||
| if let Some(s) = status { | ||
| qs.push("manga_status", Some(s)); | ||
| } | ||
| for genre in &genres { | ||
| qs.push("genre[]", Some(genre)); | ||
| } | ||
| let page_str; | ||
| let url = if page <= 1 { | ||
| format!("{}/page/1/?{qs}", BASE_URL) | ||
| } else { | ||
| page_str = page.to_string(); | ||
| let _ = &page_str; | ||
| format!("{}/page/{page}/?{qs}", BASE_URL) | ||
| }; | ||
| return parse_manga_list(&url); | ||
| } |
Contributor
There was a problem hiding this comment.
it looks like the /manga endpoint can just be given a search query parameter, so you shouldn't need to use a separate page for this.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Site migrated from aquareader.net (Madara) to aquareader.org (custom
frontend over Madara backend). Rebuilt home page parsing from scratch
using DevTools-verified selectors.
Home page:
with description (.aqua-hero-slide__excerpt) and genres
(.aqua-hero-slide__genre)
.aqua-manga-card with chapter name (.aqua-chapter-pill__name),
chapter key (a.aqua-chapter-pill href), and relative date
(.aqua-chapter-pill__time)
Manga detail page (custom selectors overriding Madara defaults):
Chapter loading:
since manga-chapters-holder data-id element no longer exists
Filter URLs:
Source URL updated to aquareader.org, version bumped to 2