MsgReader: upfront config validation + fatal NATS error classification#31
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/AkondLab/serverish/sessions/a9738867-cb3e-436c-bf7f-c8dc0e76b428 Co-authored-by: majkelx <8569721+majkelx@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing config validation and retry loop in MsgReader
MsgReader: upfront config validation + fatal NATS error classification
May 3, 2026
majkelx
requested changes
May 3, 2026
…tream subject Agent-Logs-Url: https://github.com/AkondLab/serverish/sessions/28471008-e43d-4089-bda4-f971abf2c7e6 Co-authored-by: majkelx <8569721+majkelx@users.noreply.github.com>
majkelx
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MessengerReaderConfigErrorexception toserverish/base/exceptions.py__init__validation inMsgReaderfordeliver_policy='by_start_time'(requiresopt_start_time) anddeliver_policy='by_start_sequence'(requiresopt_start_seq)nats.js.errorsinmsg_reader.pyBadRequestErrorandNotFoundErroras fatal inread_nexterror handler — raiseMessengerReaderConfigErrorimmediately regardless oferror_behaviorMessengerReaderConfigErrorfromserverish.basetest_messenger_issue5_subject_not_in_stream: update to expectMessengerReaderConfigErrorinstead of rawNotFoundError(CI fix)