refactor: extract duplicated code patterns into shared utilities#2
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
refactor: extract duplicated code patterns into shared utilities#2devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
- Add utils/embedHelpers.js: errorEmbed, successEmbed, accessDeniedEmbed, moderationSuccessEmbed - Add utils/commandHelpers.js: checkAdmin, fetchMemberOrReply, checkActionable, handleCommandError - Add utils/commandLoader.js: forEachCommand() shared by index.js and deploy-commands.js - Refactor ban, kick, mute, clear, slowmode, lock, Good commands to use shared helpers - Refactor index.js and deploy-commands.js to use commandLoader Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Seven commands (
ban,kick,mute,clear,slowmode,lock,Good) duplicated the same patterns: admin-role gate, member-fetch-or-reply, actionability check (bannable/kickable/moderatable), error-embed construction, and error-handler boilerplate.index.jsanddeploy-commands.jseach had their own copy of the command-directory traversal loop.This PR extracts those into three new shared modules:
utils/embedHelpers.jserrorEmbed(title, desc),successEmbed(title, fields, opts),accessDeniedEmbed(),moderationSuccessEmbed(title, user, reason, moderator, extraFields)utils/commandHelpers.jscheckAdmin(interaction),fetchMemberOrReply(interaction, userId),checkActionable(interaction, member, perm, actionName),handleCommandError(interaction, client, cmdName, error)utils/commandLoader.jsforEachCommand(baseDir, logger, callback)— shared iteration overcommands/*/used by bothindex.jsanddeploy-commands.jsNet result: −479 / +426 lines (−53 net), with each command file reduced to its unique logic only. All 14 commands load and resolve successfully.
Also adds the missing
package-lock.jsonto fix the preexisting CI cache failure.Link to Devin session: https://app.devin.ai/sessions/f2499b3b48cd4b8daeae817303088d33
Requested by: @AliCloud0