[pull] master from bitcoin:master#1676
Merged
Merged
Conversation
Instead we fully reset CoinsResult-instances without forgetting any fields. Fixes: #35449 Variant resetting the other fields in Clear(): ₿ hyperfine --warmup 2 "./build/bin/test_bitcoin -t coinselector_tests/knapsack_solver_test" Benchmark 1: ./build/bin/test_bitcoin -t coinselector_tests/knapsack_solver_test Time (mean ± σ): 4.289 s ± 0.008 s [User: 4.252 s, System: 0.027 s] Range (min … max): 4.279 s … 4.301 s 10 runs This variant: ₿ hyperfine --warmup 2 "./build/bin/test_bitcoin -t coinselector_tests/knapsack_solver_test" Benchmark 1: ./build/bin/test_bitcoin -t coinselector_tests/knapsack_solver_test Time (mean ± σ): 4.279 s ± 0.005 s [User: 4.244 s, System: 0.026 s] Range (min … max): 4.271 s … 4.287 s 10 runs
The test needs multiple wallets that can be created on a single node, multiple nodes are not required. As there is a cost associated with setting-up and tearing-down nodes, this patch helps in reducing the test time as well.
…atebroadcast is disabled
…e node is running without -privatebroadcast set
…cast fail if privatebroadcast is not enabled 0bfc5e4 add release notes (Pol Espinasa) fdc9fc1 test: check getprivatebroadcast and abortprivatebroadcast throw if the node is running without -privatebroadcast set (Pol Espinasa) 7b821ef rpc: getprivatebroadcastinfo and abortprivatebroadcast throw if -privatebroadcast is disabled (Pol Espinasa) Pull request description: Makes `getprivatebroadcast` and `abortprivatebroadcast` throw if `-privatebroadcast=0`. This is motivated by: sparrowwallet/sparrow#1989 Knowing if `privatebroadcast` is set can be useful for some external software like Sparrow to avoid call `getprivatebroadcastinfo` each time to see if broadcast was done through that. ACKs for top commit: stickies-v: ACK 0bfc5e4 sedited: ACK 0bfc5e4 rkrux: code review ACK 0bfc5e4 andrewtoth: ACK 0bfc5e4 Tree-SHA512: 3bdb3909e93fc3835d801e1efc2bbec673a75a1ff089debd59e8970a0ff2b44d4e00b7ac26f10c972dcb50bf042521921370e1ec57885d67cd8459b3831da898
…id passing 21M BTC d0b76c7 rpc+bitcoin-tx: Specify correct type for ParseFixedPoint() (Hodlinator) 43ca54c refactor(test): Make CAmount arg explicit for BuildCreditingTransaction() (Hodlinator) b5e91e9 wallet: Remove CoinsResult::Clear() (Hodlinator) Pull request description: The *knapsack_solver_test* in *coinselector_tests.cpp* was accumulating satoshi amounts beyond 21M BTC. This was uncovered while experimenting with adding checks to `CAmount`. Fix that by fully resetting the `CoinsResult` object accumulating those amounts, inspired by #35449 (comment). Also, while we're at it, add 2 commits which correct some `int64_t`/`CAmount` confusion. Fixes #35449 ACKs for top commit: sedited: ACK d0b76c7 furszy: utACK d0b76c7 brunoerg: code review ACK d0b76c7 Tree-SHA512: 6d989ded6f6327dc657f437dc256d4adf42a34a1252621421ee38d7851c6cdc97a462f033a4728e3aa7d5514deee4db6e83646105633f9cf7ed6e7e90406b67d
…criptor_psbt 5b65e31 test: remove two unnecessary nodes from the test (rkrux) Pull request description: A discussion in the review of #35443 PR brought this test to my attention. The test needs multiple wallets that can be created on a single node, multiple nodes are not required. As there is a cost associated with setting-up and tearing-down nodes, this patch helps in reducing the test time as well. ACKs for top commit: ekzyis: ACK 5b65e31 polespinasa: lgtm ACK 5b65e31 sedited: ACK 5b65e31 Tree-SHA512: f6b4a96b9beee968ef5438fd9db582a48834ff36ba27c19dd7012902528fa713424212530e34cc16b58c19c023f1accd2b89fe846ef2cc36677c24e160c5b817
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )