Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Doc/library/threading.rst
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ since it is impossible to detect the termination of alien threads.
This constructor should always be called with keyword arguments. Arguments
are:

*group* should be ``None``; reserved for future extension when a
*group* must be ``None`` as it is reserved for future extension when a
:class:`!ThreadGroup` class is implemented.

*target* is the callable object to be invoked by the :meth:`run` method.
Expand Down
2 changes: 1 addition & 1 deletion Include/internal/pycore_sliceobject.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ extern "C" {
/* runtime lifecycle */

PyAPI_FUNC(PyObject *)
_PyBuildSlice_ConsumeRefs(PyObject *start, PyObject *stop);
_PyBuildSlice_ConsumeRefs(PyObject *start, PyObject *stop, PyObject *step);

#ifdef __cplusplus
}
Expand Down
5 changes: 1 addition & 4 deletions Lib/asyncio/locks.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,7 @@ def _wake_up_first(self):
"""Ensure that the first waiter will wake up."""
if not self._waiters:
return
try:
fut = next(iter(self._waiters))
except StopIteration:
return
fut = next(iter(self._waiters))

# .done() means that the waiter is already set to wake up.
if not fut.done():
Expand Down
12 changes: 12 additions & 0 deletions Lib/profiling/sampling/_flamegraph_assets/flamegraph.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ let invertedData = null;
let currentThreadFilter = 'all';
let isInverted = false;
let useModuleNames = true;
let zoomedNodeValue = null;

// Heat colors are now defined in CSS variables (--heat-1 through --heat-8)
// and automatically switch with theme changes - no JS color arrays needed!
Expand Down Expand Up @@ -316,6 +317,7 @@ function createPythonTooltip(data) {
const selfSamples = d.data.self || 0;
const selfMs = (selfSamples / 1000).toFixed(2);
const percentage = ((d.data.value / data.value) * 100).toFixed(2);
const relativePercentage = Math.min(100, ((d.data.value / (zoomedNodeValue ?? data.value)) * 100)).toFixed(2);
const calls = d.data.calls || 0;
const childCount = d.children ? d.children.length : 0;
const source = d.data.source;
Expand Down Expand Up @@ -439,6 +441,11 @@ function createPythonTooltip(data) {
<span class="tooltip-stat-label">Percentage:</span>
<span class="tooltip-stat-value accent">${percentage}%</span>

${relativePercentage != percentage && relativePercentage != "100.00" ? `
<span class="tooltip-stat-label">Relative Percentage:</span>
<span class="tooltip-stat-value accent">${relativePercentage}%</span>
` : ''}

${calls > 0 ? `
<span class="tooltip-stat-label">Function Calls:</span>
<span class="tooltip-stat-value">${calls.toLocaleString()}</span>
Expand Down Expand Up @@ -620,6 +627,9 @@ function createFlamegraph(tooltip, rootValue, data) {
const percentage = d.data.value / rootValue;
const level = getHeatLevel(percentage);
return heatColors[level];
})
.onClick(function (d) {
zoomedNodeValue = d.data.value;
});

return chart;
Expand All @@ -629,6 +639,7 @@ function renderFlamegraph(chart, data) {
d3.select("#chart").datum(data).call(chart);
window.flamegraphChart = chart;
window.flamegraphData = data;
zoomedNodeValue = null;
populateStats(data);
}

Expand Down Expand Up @@ -1269,6 +1280,7 @@ function filterDataByThread(data, threadId) {

function resetZoom() {
if (window.flamegraphChart) {
zoomedNodeValue = null;
window.flamegraphChart.resetZoom();
}
}
Expand Down
20 changes: 20 additions & 0 deletions Lib/test/test_type_cache.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
""" Tests for the internal type cache in CPython. """
import collections.abc
import dis
import unittest
import warnings
Expand Down Expand Up @@ -114,6 +115,25 @@ class HolderSub(Holder):
Holder.set_value()
HolderSub.value

def test_abc_register_invalidates_subclass_versions(self):
class Parent:
pass

class Child(Parent):
pass

type_assign_version(Parent)
type_assign_version(Child)
parent_version = type_get_version(Parent)
child_version = type_get_version(Child)
if parent_version == 0 or child_version == 0:
self.skipTest("Could not assign valid type versions")

collections.abc.Mapping.register(Parent)

self.assertEqual(type_get_version(Parent), 0)
self.assertEqual(type_get_version(Child), 0)

@support.cpython_only
class TypeCacheWithSpecializationTests(unittest.TestCase):
def tearDown(self):
Expand Down
11 changes: 10 additions & 1 deletion Makefile.pre.in
Original file line number Diff line number Diff line change
Expand Up @@ -3111,9 +3111,18 @@ config.status: $(srcdir)/configure

.PRECIOUS: config.status $(BUILDPYTHON) Makefile Makefile.pre

Python/asm_trampoline.o: $(srcdir)/Python/asm_trampoline.S
Python/asm_trampoline_x86_64.o: $(srcdir)/Python/asm_trampoline_x86_64.S
$(CC) -c $(PY_CORE_CFLAGS) -o $@ $<

Python/asm_trampoline_aarch64.o: $(srcdir)/Python/asm_trampoline_aarch64.S
$(CC) -c $(PY_CORE_CFLAGS) -o $@ $<

Python/asm_trampoline_riscv64.o: $(srcdir)/Python/asm_trampoline_riscv64.S
$(CC) -c $(PY_CORE_CFLAGS) -o $@ $<

Python/asm_trampoline_universal2.o: Python/asm_trampoline_aarch64.o Python/asm_trampoline_x86_64.o
lipo -create -output $@ Python/asm_trampoline_aarch64.o Python/asm_trampoline_x86_64.o

Python/emscripten_trampoline_inner.wasm: $(srcdir)/Python/emscripten_trampoline_inner.c
# emcc has a path that ends with emsdk/upstream/emscripten/emcc, we're looking for emsdk/upstream/bin/clang.
$$(dirname $$(dirname $(CC)))/bin/clang -o $@ $< -mgc -O2 -Wl,--no-entry -Wl,--import-table -Wl,--import-memory -target wasm32-unknown-unknown -nostdlib
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix ``abc.register()`` so it invalidates type version tags for registered classes.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update the tooltip on the Tachyon flame graph to show both absolute and relative percentages.
2 changes: 2 additions & 0 deletions Modules/_io/bufferedio.c
Original file line number Diff line number Diff line change
Expand Up @@ -1509,7 +1509,9 @@ buffered_iternext(PyObject *op)
tp == state->PyBufferedRandom_Type)
{
/* Skip method call overhead for speed */
Py_BEGIN_CRITICAL_SECTION(self);
line = _buffered_readline(self, -1);
Py_END_CRITICAL_SECTION();
}
else {
line = PyObject_CallMethodNoArgs((PyObject *)self,
Expand Down
3 changes: 2 additions & 1 deletion Modules/_testinternalcapi/test_cases.c.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 8 additions & 16 deletions Objects/sliceobject.c
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ PyObject _Py_EllipsisObject = _PyObject_HEAD_INIT(&PyEllipsis_Type);
index is present.
*/

static PySliceObject *
_PyBuildSlice_Consume2(PyObject *start, PyObject *stop, PyObject *step)
PyObject *
_PyBuildSlice_ConsumeRefs(PyObject *start, PyObject *stop, PyObject *step)
{
assert(start != NULL && stop != NULL && step != NULL);
PySliceObject *obj = _Py_FREELIST_POP(PySliceObject, slices);
Expand All @@ -131,13 +131,14 @@ _PyBuildSlice_Consume2(PyObject *start, PyObject *stop, PyObject *step)

obj->start = start;
obj->stop = stop;
obj->step = Py_NewRef(step);
obj->step = step;

_PyObject_GC_TRACK(obj);
return obj;
return (PyObject *)obj;
error:
Py_DECREF(start);
Py_DECREF(stop);
Py_DECREF(step);
return NULL;
}

Expand All @@ -153,15 +154,8 @@ PySlice_New(PyObject *start, PyObject *stop, PyObject *step)
if (stop == NULL) {
stop = Py_None;
}
return (PyObject *)_PyBuildSlice_Consume2(Py_NewRef(start),
Py_NewRef(stop), step);
}

PyObject *
_PyBuildSlice_ConsumeRefs(PyObject *start, PyObject *stop)
{
assert(start != NULL && stop != NULL);
return (PyObject *)_PyBuildSlice_Consume2(start, stop, Py_None);
return _PyBuildSlice_ConsumeRefs(Py_NewRef(start),
Py_NewRef(stop), Py_NewRef(step));
}

PyObject *
Expand All @@ -177,9 +171,7 @@ _PySlice_FromIndices(Py_ssize_t istart, Py_ssize_t istop)
return NULL;
}

slice = PySlice_New(start, end, NULL);
Py_DECREF(start);
Py_DECREF(end);
slice = _PyBuildSlice_ConsumeRefs(start, end, Py_None);
return slice;
}

Expand Down
16 changes: 16 additions & 0 deletions Objects/typeobject.c
Original file line number Diff line number Diff line change
Expand Up @@ -6490,9 +6490,25 @@ set_flags_recursive(PyTypeObject *self, unsigned long mask, unsigned long flags)
void
_PyType_SetFlagsRecursive(PyTypeObject *self, unsigned long mask, unsigned long flags)
{
BEGIN_TYPE_LOCK();
/* Ideally, changing flags and invalidating the old version tag would
happen in one step. But type_modified_unlocked() is re-entrant and
cannot run with the world stopped, so we must invalidate first.
Immutable/static-builtin types are skipped because
set_flags_recursive() does not modify them. */
if (!PyType_HasFeature(self, Py_TPFLAGS_IMMUTABLETYPE) &&
(self->tp_flags & mask) != flags)
{
type_modified_unlocked(self);
}
/* Keep TYPE_LOCK held while waiting for stop-the-world so no thread
can reassign a version tag before the flag update. */
type_lock_prevent_release();
types_stop_world();
set_flags_recursive(self, mask, flags);
types_start_world();
type_lock_allow_release();
END_TYPE_LOCK();
}

/* This is similar to PyObject_GenericGetAttr(),
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
#ifndef ASM_TRAMPOLINE_AARCH_64_H_
#define ASM_TRAMPOLINE_AARCH_64_H_

/*
* References:
* - https://developer.arm.com/documentation/101028/0012/5--Feature-test-macros
Expand Down Expand Up @@ -38,6 +35,31 @@
#define GNU_PROPERTY_AARCH64_GCS 0
#endif

.text
#if defined(__aarch64__) && defined(__AARCH64EL__) && !defined(__ILP32__)
#if defined(__APPLE__)
.globl __Py_trampoline_func_start
__Py_trampoline_func_start:
#else
.globl _Py_trampoline_func_start
_Py_trampoline_func_start:
#endif
SIGN_LR
stp x29, x30, [sp, -16]!
mov x29, sp
blr x3
ldp x29, x30, [sp], 16
VERIFY_LR
ret
#if defined(__APPLE__)
.globl __Py_trampoline_func_end
__Py_trampoline_func_end:
#else
.globl _Py_trampoline_func_end
_Py_trampoline_func_end:
.section .note.GNU-stack,"",@progbits
#endif

/* Add the BTI, PAC and GCS support to GNU Notes section */
#if GNU_PROPERTY_AARCH64_BTI != 0 || GNU_PROPERTY_AARCH64_POINTER_AUTH != 0 || GNU_PROPERTY_AARCH64_GCS != 0
.pushsection .note.gnu.property, "a"; /* Start a new allocatable section */
Expand All @@ -52,5 +74,4 @@
.long 0; /* padding for 8 byte alignment */
.popsection; /* end the section */
#endif

#endif
#endif // __aarch64__ && __AARCH64EL__ && !__ILP32__
12 changes: 12 additions & 0 deletions Python/asm_trampoline_riscv64.S
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
.text
.globl _Py_trampoline_func_start
_Py_trampoline_func_start:
addi sp,sp,-16
sd ra,8(sp)
jalr a3
ld ra,8(sp)
addi sp,sp,16
jr ra
.globl _Py_trampoline_func_end
_Py_trampoline_func_end:
.section .note.GNU-stack,"",@progbits
39 changes: 4 additions & 35 deletions Python/asm_trampoline.S → Python/asm_trampoline_x86_64.S
Original file line number Diff line number Diff line change
@@ -1,24 +1,12 @@
#include "asm_trampoline_aarch64.h"

.text
#ifdef __x86_64__
#if defined(__APPLE__)
.globl __Py_trampoline_func_start
#else
.globl _Py_trampoline_func_start
#endif
# The following assembly is equivalent to:
# PyObject *
# trampoline(PyThreadState *ts, _PyInterpreterFrame *f,
# int throwflag, py_evaluator evaluator)
# {
# return evaluator(ts, f, throwflag);
# }
#if defined(__APPLE__)
__Py_trampoline_func_start:
#else
.globl _Py_trampoline_func_start
_Py_trampoline_func_start:
#endif
#ifdef __x86_64__
#if defined(__CET__) && (__CET__ & 1)
endbr64
#endif
Expand All @@ -27,26 +15,6 @@ _Py_trampoline_func_start:
call *%rcx
pop %rbp
ret
#endif // __x86_64__
#if defined(__aarch64__) && defined(__AARCH64EL__) && !defined(__ILP32__)
// ARM64 little endian, 64bit ABI
// generate with aarch64-linux-gnu-gcc 12.1
SIGN_LR
stp x29, x30, [sp, -16]!
mov x29, sp
blr x3
ldp x29, x30, [sp], 16
VERIFY_LR
ret
#endif
#ifdef __riscv
addi sp,sp,-16
sd ra,8(sp)
jalr a3
ld ra,8(sp)
addi sp,sp,16
jr ra
#endif
#if defined(__APPLE__)
.globl __Py_trampoline_func_end
__Py_trampoline_func_end:
Expand All @@ -56,7 +24,7 @@ _Py_trampoline_func_end:
.section .note.GNU-stack,"",@progbits
#endif
# Note for indicating the assembly code supports CET
#if defined(__x86_64__) && defined(__CET__) && (__CET__ & 1)
#if defined(__CET__) && (__CET__ & 1)
.section .note.gnu.property,"a"
.align 8
.long 1f - 0f
Expand All @@ -73,4 +41,5 @@ _Py_trampoline_func_end:
3:
.align 8
4:
#endif
#endif // __x86_64__
3 changes: 2 additions & 1 deletion Python/bytecodes.c
Original file line number Diff line number Diff line change
Expand Up @@ -1116,7 +1116,8 @@ dummy_func(

op(_STORE_SLICE, (v, container, start, stop -- )) {
PyObject *slice = _PyBuildSlice_ConsumeRefs(PyStackRef_AsPyObjectSteal(start),
PyStackRef_AsPyObjectSteal(stop));
PyStackRef_AsPyObjectSteal(stop),
Py_None);
int err;
if (slice == NULL) {
err = 1;
Expand Down
3 changes: 2 additions & 1 deletion Python/executor_cases.c.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading