[pull] master from web-platform-tests:master#2255
Merged
Merged
Conversation
The original test has implicit timing assumptions about when events would be dispatched relative to animation frame timing. This test was also failing on webkit, which supports SDA. The updated test, has fewer moving parts (pun intended) and works with or without the snapshot post layout experiment. Fixing as part of Interop 2026 Bug: 384523570 Change-Id: I84c223d7ca8e8aa1c238bd5b099f94a8712c33aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7718838 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1609258}
Avoid a Timeout on Firefox that was triggered by a call to create a scrollTimeline. Firefox now fails quickly on the assert_implements call.
When an animation is in effect it should not be GC'd, as GC should not affect the lifetime of animations and only collect animations that no longer have an effect or reference. Bug: 427535093 Change-Id: I65dd04268679edbdb9f18abe0915aa3d3367878c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7920346 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1645371}
For non-intercepted navigations, the "navigatesuccess" event should fire before the promises resolve. This test fails because of the "WaitForAll" change and this fix should make it pass in Firefox as well. Bug: 519062396 Change-Id: Ie1e6bd1953b09148fbe68716935547f788421bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7902273 Commit-Queue: Noam Rosenthal <nrosenthal@google.com> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1641742}
The test waited for the iframe to load, but not for the script inside the iframe to execute. Bug: 40769897 Change-Id: I648bd9d60fcb8aff474e1ba05d9f2e665d9b278e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7914701 Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1645417}
Add a CSSNumericValue.parse() test for calc() complex expression. The new test verifies that a complex expression is reified as a nested CSSMathSum containing CSSMathNegate and CSSMathProduct arguments, matching the math expression reification algorithm. Differential Revision: https://phabricator.services.mozilla.com/D304702 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2044316 gecko-commit: a72efd7a2c5ca78024151e5bba11cf1f15e41711 gecko-commit-git: fb00164beea8e792ae32dcc45ed6c030f0768a8b gecko-reviewers: emilio, firefox-style-system-reviewers
Escaped media features and custom property features were not escaped on serialization. Use SerializeIdentifier() instead of Append(). Bug: 518112775, 517693726 Change-Id: Ibfa43b9a7d925a3efe65049fb80b8309353a46c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7900079 Reviewed-by: Steinar H Gunderson <sesse@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1643107}
A column wrapping flexbox will use its min-block-size/max-block-size to wrap items, and change its min/max-sizes. If the initial-block-size was indefinite, we'd incorrectly hit the cache. Instead of this skip the cache if we have percent/stretch within the min/max block-sizes. We could add a "line-break-size" or similar to the cache key, but for the moment this is ok. Fixed: 490318093 Change-Id: Icb1a189a595fa9be11d5b15fcda1f89d9447f4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7921611 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1645459}
* Add whitespace alt in srcset tests * Apply suggestions from code review Co-authored-by: Adam Page <adam@adampage.net> * Update img-src-srcset-roles.tentative.html linter issue fixed --------- Co-authored-by: Adam Page <adam@adampage.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )