[pull] master from web-platform-tests:master#2256
Merged
Merged
Conversation
…eOverride" in workers. Differential Revision: https://phabricator.services.mozilla.com/D300755 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2015657 gecko-commit: 51f2c32e35360160ead83d489ba696c653468958 gecko-commit-git: 489d11925c63d700d7d637be7345035685566d45 gecko-reviewers: jdescottes
This change introduces a new `cancel` event for the `<usermedia>` element. This event is dispatched when the user explicitly denies or dismisses the permission prompt associated with the element. Spec: https://w3c.github.io/mediacapture-extensions/#the-usermedia-html-element Bug: 519071684 Change-Id: Ibccf36b78841809b501f144ea46a0cc2c6026c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7882422 Auto-Submit: Ravjit Uppal <ravjit@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1645659}
Per step 1 of the DOM spec's "attach a shadow root" [1], Element.attachShadow() should check that the element's namespace is the HTML namespace before allowing shadow root attachment. Add a UseCounter to see how often attachShadow is called for non- HTML elements, and add the check to disallow it behind an experimental flag. [1] https://dom.spec.whatwg.org/#concept-attach-a-shadow-root Bug: 521896365 Change-Id: I5253eee863920a1ea7f7de48086355318b2982bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7915190 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1645719}
The port component encoding function previously used a fake URL with
an HTTPS scheme for canonicalization [1]. Under the URL specification,
replacing a port that matches the default port of a special scheme
(such as 443 for HTTPS) strips the port string, resulting in an
empty string [2].
This behavior is spec-compliant but violates an internal precondition in
the `Part` structure, which expects `kFixed` parts to have non-empty
string values.
To address this, tentatively switch to a fake URL with a non-special
scheme ("dummy://") during port encoding. This prevents the URL
parser from stripping default ports. Additionally, introduce a
validation check and assertion to ensure that non-empty input port
components remain non-empty after encoding.
[1] https://url.spec.whatwg.org/#port-state
[2] https://urlpattern.spec.whatwg.org/#canonicalize-a-port
Bug: 520829534
Change-Id: Icae502be44999d3bfaae8e2c29b6450dc7fa4968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7924108
Reviewed-by: Shunya Shishido <sisidovski@chromium.org>
Commit-Queue: Takashi Nakayama <tnak@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1645725}
This CL raises the input rank limit from 4 to 5 for the six comparison operators equal, notEqual, greater, greaterOrEqual, lesser and lesserOrEqual on the TFLite backend, aligning them with the other element-wise logical operators. This CL also adds conformance tests for the new rank-5 paths. Change-Id: I8a7710c6c24997bd5b49e8f47cc478be6bcfe67e Bug: 521893563 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, win11-arm64-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7914923 Commit-Queue: Dai, Feng <feng.dai@intel.com> Auto-Submit: Dai, Feng <feng.dai@intel.com> Reviewed-by: Hu, Ningxin <ningxin.hu@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1645738}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )