Varkopat/enhancement/645 update privacy policy page terms conditions#651
Open
Varkopat wants to merge 7 commits into
Open
Varkopat/enhancement/645 update privacy policy page terms conditions#651Varkopat wants to merge 7 commits into
Varkopat wants to merge 7 commits into
Conversation
- Added page description to the privacy page. - Updated privacy sections to include new topics such as age limits, Discord community, and ethical principles. - Implemented new styles for the privacy page layout and accordion functionality. - Enhanced localization files for English and Finnish to reflect updated content. - Improved WikiContentWithSidebar component to support collapsible sections with smooth transitions. Co-authored-by: Copilot <copilot@github.com>
Varkopat
requested review from
Rutjake,
Skoivumaki,
leolabdev and
patinen
as code owners
Skoivumaki
requested changes
May 14, 2026
Member
There was a problem hiding this comment.
Good work. I'm noticing a pattern of quite excessive commenting to a point of it reducing readability. See this for a guide about good code comment practices to avoid it in the future. However your commit messages are solid and with expected frequency 👍
Todo:
- Remove sidebar from page. It is no longer necessary with accordion layout.
- Remove unnecessary comments. (for all files)
- Fix chevron rotation. (currently its rotating the wrong way)
- See comments.
@Rutjake I'll leave theming/styling review up to you.
Member
There was a problem hiding this comment.
Dont leave "what was done" comments into files, instead explain what and why changes were made in commits. The Privacy Page Styles Module part is relevant and useful here.
Member
There was a problem hiding this comment.
Excessive commenting. All variables are self-explanatory.
| * Chevron icon container for expand/collapse indicator | ||
| * | ||
| * @styling | ||
| * - Initially rotated 270 degrees (pointing right/left depending on RTL) |
Member
There was a problem hiding this comment.
In the issue: It should rotate 90° when the section is active/expanded to provide clear visual feedback.
Member
There was a problem hiding this comment.
You made changes to a file that is referenced on 2 other pages as well. Did you test how these changes affect the other pages? Document your findings in PR.
Author
There was a problem hiding this comment.
I documented my findings in PR. Now I'm wondering if the accordion related codes are necessary now that the sidebar is removed from the Privacy Page and all accordion related code is now there and in the Privacy.module.scss file?
Author
|
Thanks for your feedback. I'll begin to work on the changes suggested 👍 |
…d info box support - Removed unnecessary comments The following changes were made to Privacy.module.scss: /** * Accordion Styles Module * * This section contains all CSS classes for the accordion/collapsible section functionality. * The accordion allows sections to expand and collapse with smooth animations. */ /** * Main collapsible section container * * @styling * - Creates the outer wrapper for each accordion item * - Applies background color, border, and shadow styling consistent with section design * - Provides container for header and collapsible content * - Enhanced shadow on hover for visual feedback */ /** * Section header (clickable button area) * * @styling * - Flexbox layout for aligning title and chevron icon * - Full width, padded clickable area * - Subtle background color change on hover for interactivity feedback * - Focus visible outline for keyboard navigation accessibility * - Text alignment set to left for proper content alignment */ /** * Section title text styling * * @styling * - Primary color to match component branding * - Large font size (font-sw-xl) for prominence * - Flexible width to accommodate long titles * - Word-break enabled to handle long text gracefully */ /** * Chevron icon container for expand/collapse indicator * * @styling * - Initially rotated 90 degrees (pointing right/left depending on RTL) * - Rotates to 0 degrees when section is expanded * - Smooth transition animation (0.3s ease) * - Flexbox centered alignment * - No flex-shrink to maintain consistent size */ /** * Chevron icon rotated state * * @styling * - Applied when accordion section is expanded * - Rotates chevron to 0 degrees (pointing down) * - Pairs with animation defined in .chevronIcon */ /** * Collapsible content area wrapper * * @styling * - Max-height starts at 0px (fully collapsed) * - Content hidden when collapsed (overflow: hidden) * - Smooth height and opacity transitions for expand/collapse animation * - Opacity transition delayed to create staggered animation effect * - Recalculates max-height dynamically based on content size */ /** * Expanded state for section content * * @styling * - Applied to .sectionContent when parent .collapsibleSection.expanded * - Opacity transitions to full visibility * - Transition timing adjusted for smooth appear animation */ /** * Inner content wrapper inside collapsible area * * @styling * - Padding applied to create spacing around content * - Contains paragraphs and images with consistent typography * - Paragraph styling with white color, readable line-height * - Link colors with hover transitions for interactivity */ /* Accordion/Collapsible Section Styles */
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Pull Request Overview
Closes #645
🔧 Changes Made
Added page description to the privacy page.
Updated privacy sections to include new topics such as age limits, Discord community, and ethical principles.
Implemented new styles for the privacy page layout and accordion functionality.
Enhanced localization files for English and Finnish to reflect updated content.
Improved WikiContentWithSidebar component to support collapsible sections with smooth transitions. I am aware that WikiContentWithSidebar is referenced on 2 other pages as well. I have tested how these changes affect the other pages. Everything worked fine in my tests.
✅ Checklist Before Submission
console.log()or other debugging statements are left.📝 Additional Information
Provide any additional context or information that reviewers may need to know: