Include new parameters in session and authorize to support MarketPay integration - #158
Open
BushraAsif wants to merge 9 commits into
Open
Include new parameters in session and authorize to support MarketPay integration#158BushraAsif wants to merge 9 commits into
BushraAsif wants to merge 9 commits into
Conversation
Copilot stopped work on behalf of
BushraAsif due to an error
August 7, 2026 12:24
emicha
reviewed
Aug 11, 2026
| { | ||
| $db = Db::getInstance(); | ||
|
|
||
| $uniqueId = $db->getValue('SELECT unique_id FROM `' . _DB_PREFIX_ . 'altapay_transaction` WHERE id_cart = ' . $cartId); |
Member
There was a problem hiding this comment.
Remember to cast, you can't guarantee that the layer using the method will do the casting for you
emicha
reviewed
Aug 11, 2026
| @@ -17,23 +19,112 @@ public function postProcess() | |||
| { | |||
| $currentShopId = $this->context->shop->id; | |||
| $validationUrl = Tools::getValue('validationUrl'); | |||
Member
There was a problem hiding this comment.
Shouldn't we validate this is a valid url ?
Contributor
Author
There was a problem hiding this comment.
Good catch — I’ve added a check for this now.
emicha
reviewed
Aug 11, 2026
| ->setDomain($domain); | ||
|
|
||
| if (!$terminal->applepay_legacy_flow) { | ||
| $requestedAmount = (float) Tools::getValue('amount'); |
Member
There was a problem hiding this comment.
Casting can return valid numeric values for bad input such as "", boolean, etc.
This can caause the requested amount to be an unexpected value
Ensure requested amount is numeric and validate URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.