feat: Add bytemuck crate support for Pod types - #49
Merged
Conversation
williamwutq
changed the title
williamwutq
force-pushed
the
bytemuck
branch
from
September 4, 2026 06:25
eb2e11b to
f96b311
Compare
Altair-Bueno
requested changes
Sep 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #49 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 26 +1
Lines 1025 1068 +43
=========================================
+ Hits 1025 1068 +43
🚀 New features to boost your workflow:
|
williamwutq
force-pushed
the
bytemuck
branch
from
September 4, 2026 21:11
9ecd31e to
f758fd3
Compare
williamwutq
force-pushed
the
bytemuck
branch
from
September 4, 2026 21:16
f758fd3 to
fcdd648
Compare
Contributor
Author
|
See my reply to your comment @Altair-Bueno. Currently on this branch, on be machines, BE of Pod implements Encodable, and on le machines, LE of Pod implements Encodable, as there is no canonical way to reverse the endianness of a Pod struct. Since no unsafe code is allowed, |
Contributor
Author
|
@Altair-Bueno Changed according to your intention (plan 2 with native endian order, documented). Please do another review. Thanks |
The bytemuck bullet exceeded prettier's `proseWrap: always` width, failing the prettier-fmt job. Also keeps the feature and dependency entries alphabetically sorted alongside `arrayvec` and `bytes`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Point users at the LE/BE combinators when a stable wire format is needed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Altair-Bueno
approved these changes
Sep 7, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wanting to use something for serialization and this crate looks great. As a bytemuck user, it would be nice to have some bytemuck integration, so I hope this PR can bring it to this crate.