Fix date to allow commits to vault after 2020 to be transferred#24
Open
davidasconsulting wants to merge 1 commit into
Open
Fix date to allow commits to vault after 2020 to be transferred#24davidasconsulting wants to merge 1 commit into
davidasconsulting wants to merge 1 commit into
Conversation
| 1, | ||
| VaultDateTime.Parse("2000-01-01"), | ||
| VaultDateTime.Parse("2020-01-01"), | ||
| VaultDateTime.Parse("2120-01-01"), |
Owner
There was a problem hiding this comment.
What versions of Vault did you check this parsing with? Just confirming there is no max supported date in vault dlls themselves.
Owner
There was a problem hiding this comment.
To avoid extensive manual testing on all versions of Vault, please use currentDate + 2 for the second argument.
Author
There was a problem hiding this comment.
I will work on this in a few days.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing code stops at Jan 1, 2020. This change will keep this project running until 2120.
It would be better to make the date dependent on current date, but it is a riskier change and not worth it in my opinion.