Extract resource-aware optimization logic into a tested module - #1
Open
denis-samatov wants to merge 1 commit into
Open
Extract resource-aware optimization logic into a tested module#1denis-samatov wants to merge 1 commit into
denis-samatov wants to merge 1 commit into
Conversation
Extracts the classify-route-respond logic from the resource-aware optimization notebook into notebooks/resource_aware_optimization.py, adds a comprehensive test suite (18 tests, all mocked -- no live API calls), and fixes several issues found along the way: - Remove a hardcoded fallback API key. - Fix a prompt-injection vulnerability. - Make JSON parsing of LLM responses robust to markdown code fences and leading/trailing text, with a safe fallback instead of raising. - Add a timeout to the Google Custom Search HTTP request. - Handle search errors in handle_prompt instead of letting them propagate uncaught. - Remove dead/commented-out code. Verified: all 18 tests pass (pytest, mocked openai/requests/dotenv, no network access needed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notebooks/resource_aware_optimization.pyhandle_promptinstead of letting them propagate uncaughtTest plan
pytest notebooks/test_resource_aware_optimization.py— 18/18 passed (mockedopenai/requests/dotenv, no network access needed)