Remove unused nest_asyncio in favor of top-level await in Copy of 5_tool_calling.ipynb - #4
Open
denis-samatov wants to merge 1 commit into
Conversation
…calling.ipynb In modern notebook environments, asyncio.run() often fails because an event loop is already running. This removes the nest_asyncio import/apply() calls and updates all relevant cells to use await directly instead, which is the standard practice in that situation. Note: this diff also reformats the notebook's JSON (pretty-printed instead of minified), a side effect of editing it programmatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In modern notebook environments,
asyncio.run()often fails because an event loop is already running. This removes thenest_asyncioimport/apply()calls and updates all relevant cells (3, 15, 25, 27) to useawaitdirectly instead, which is the standard practice in that situation.Note: this diff also reformats the notebook's JSON (pretty-printed instead of minified), a side effect of editing it programmatically.
Test plan
nest_asyncio