fix: write ColBERT training TSV exports as UTF-8#283
Open
Solaris-star wants to merge 1 commit into
Open
Conversation
Windows default locales (e.g. cp1252) raise UnicodeEncodeError on non-ASCII query/corpus text in export_training_data. Always open the TSV files with encoding="utf-8". Fixes AnswerDotAI#268
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TrainingDataProcessor.export_training_dataopened the ColBERT training TSV files with the platform default encoding. On Windows that is oftencp1252, which raisesUnicodeEncodeErrorfor characters such as Turkishı(\u0131) duringtrainer.prepare_training_data().Change
queries.train.colbert.tsvandcorpus.train.colbert.tsvwithencoding="utf-8".Test plan
test_export_training_data_writes_utf8(no network)open(...)call sites passencoding="utf-8"Fixes #268