Skip to content

fix(search): apply publicProductCondition to filter inactive and draft products from search - #1706

Open
Pratyush-Panda-2006 wants to merge 1 commit into
AnthropicBots:mainfrom
Pratyush-Panda-2006:fix/search-product-visibility
Open

fix(search): apply publicProductCondition to filter inactive and draft products from search#1706
Pratyush-Panda-2006 wants to merge 1 commit into
AnthropicBots:mainfrom
Pratyush-Panda-2006:fix/search-product-visibility

Conversation

@Pratyush-Panda-2006

Copy link
Copy Markdown
Contributor

Description

Fixes draft, archived, and inactive product exposure in \�ackend/controllers/searchController.js. Previously, search queries and fallback queries checked only \deleted_at IS NULL\ and omitted \status = 'active', which exposed unpublished draft items in search results and caused 404 links on the storefront.

Related Issue

Closes #1691

Clean Architecture & Changes

  • Imported and applied canonical \publicProductCondition('products')\ in \searchProducts\ (both primary fulltext and fallback queries).
  • Added unit tests in \�ackend/tests/searchVisibility.test.js\ validating SQL condition parameters and draft exclusions.

Verification

  • Run
    px jest tests/searchVisibility.test.js\ (All unit tests passing cleanly).

@hydra-maintainer

Copy link
Copy Markdown

🔍 Quality Gate Report

✅ All quality gates passed!

Status Check Details
Linked Issue PR description references a closing issue ✅

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

@Pratyush-Panda-2006 is attempting to deploy a commit to the Bhuvansh's projects Team on Vercel.

A member of the Team first needs to authorize it.

@hydra-maintainer

Copy link
Copy Markdown

🤖 AI Code Review

🔴 Score: 50/100 | comment

AI review unavailable at this time.


Automated AI review — a human maintainer will also review.

@hydra-maintainer

Copy link
Copy Markdown

💡 Suggested reviewers based on relevant file history: @Aditya8369, @MOHITKOURAV01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Inactive and Draft Products Displayed in Product Search Results and Autocomplete

1 participant