Skip to content

fix(inventory): serialize variant locks using resolved variant ID to prevent double-booking - #1727

Open
Pratyush-Panda-2006 wants to merge 1 commit into
AnthropicBots:mainfrom
Pratyush-Panda-2006:fix/inventory-reservation-variant-key
Open

fix(inventory): serialize variant locks using resolved variant ID to prevent double-booking#1727
Pratyush-Panda-2006 wants to merge 1 commit into
AnthropicBots:mainfrom
Pratyush-Panda-2006:fix/inventory-reservation-variant-key

Conversation

@Pratyush-Panda-2006

Copy link
Copy Markdown
Contributor

Description

Fixes race condition and double-booking in \�ackend/services/inventoryReservationService.js. Previously, when an order line with color/size was submitted without explicit \�ariantId,
esolveLockVariant\ found the variant record but \line.variantId\ was left as \

@hydra-maintainer

Copy link
Copy Markdown

🔍 Quality Gate Report

❌ Some gates need attention.

Status Check Details
Linked Issue Add Closes #N to your PR description ❌

Please address failing checks before requesting a review.

@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

@Pratyush-Panda-2006 is attempting to deploy a commit to the Bhuvansh's projects Team on Vercel.

A member of the Team first needs to authorize it.

@hydra-maintainer

Copy link
Copy Markdown

🤖 AI Code Review

🔴 Score: 50/100 | comment

AI review unavailable at this time.


Automated AI review — a human maintainer will also review.

@hydra-maintainer

Copy link
Copy Markdown

💡 Suggested reviewers based on relevant file history: @Aditya8369, @MOHITKOURAV01

@hydra-maintainer

Copy link
Copy Markdown

🟡 PR Health Score: 50/100

This PR's health score is below the 75/100 threshold for a healthy label.

Status Signal
Test coverage
Linked issue
PR description (≥50 chars)
DCO sign-off
⬜ 0 approval(s) Approvals
Diff size < 400 lines

Improving these signals will help reviewers engage faster and raise your score. 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant