fix(stock-counter): exclude soft-deleted product variants from resolveVariant queries - #1729
Open
Pratyush-Panda-2006 wants to merge 1 commit into
Conversation
…eVariant queries Closes AnthropicBots#1724
🔍 Quality Gate Report✅ All quality gates passed!
|
|
@Pratyush-Panda-2006 is attempting to deploy a commit to the Bhuvansh's projects Team on Vercel. A member of the Team first needs to authorize it. |
🤖 AI Code Review🔴 Score: 50/100 | AI review unavailable at this time. Automated AI review — a human maintainer will also review. |
|
💡 Suggested reviewers based on relevant file history: @Aditya8369, @MOHITKOURAV01 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes matching and stock deduction on soft-deleted product variants in \�ackend/services/stockCounterService.js. Previously,
esolveVariant\ checked \is_active = 1\ but omitted \deleted_at IS NULL, creating a discrepancy with \getVariantRollup\ and allowing deleted variants to be resolved and sold during checkout.
Related Issue
Closes #1724
Clean Architecture & Changes
esolveVariant().
Verification
px jest tests/stockCounterDeletedVariant.test.js\ (All unit tests passing cleanly).