Skip to content

Fix crash on executing the SaveComponentToTag predicate function to recipe items 修复对配方物品执行 SaveComponentToTag 谓词函数时发生崩溃的问题 #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PopSlime wants to merge 1 commit into
base: dev/26.1
Choose a base branch
from
Open

Fix crash on executing the SaveComponentToTag predicate function to recipe items 修复对配方物品执行 SaveComponentToTag 谓词函数时发生崩溃的问题 #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions module.recipe/src/main/java/dev/anvilcraft/lib/v2/recipe/predicate/item/HasItemBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,16 @@
import dev.anvilcraft.lib.v2.recipe.AnvilLibRecipe;
import dev.anvilcraft.lib.v2.recipe.cache.ItemCache;
import dev.anvilcraft.lib.v2.recipe.cache.item.ICacheInput;
import dev.anvilcraft.lib.v2.util.predicate.IItemStackPredicate;
import dev.anvilcraft.lib.v2.recipe.predicate.IRecipePredicate;
import dev.anvilcraft.lib.v2.recipe.predicate.function.IPredicateFunction;
import dev.anvilcraft.lib.v2.recipe.util.InWorldRecipeContext;
import dev.anvilcraft.lib.v2.recipe.util.InWorldRecipeData;
import dev.anvilcraft.lib.v2.util.predicate.IItemStackPredicate;
import lombok.Getter;
import net.minecraft.network.RegistryFriendlyByteBuf;
import net.minecraft.network.codec.ByteBufCodecs;
import net.minecraft.network.codec.StreamCodec;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.item.ItemStackTemplate;
import net.minecraft.world.phys.Vec3;

import java.util.List;
Expand Down Expand Up @@ -76,8 +76,9 @@ public void accept(InWorldRecipeContext context) {
ICacheInput item1 = this.getItem(context);
item1.apply(itemStack -> {
for (IPredicateFunction<?> function : this.functions) {
IPredicateFunction<ItemStack> function1 = (IPredicateFunction<ItemStack>) function;
itemStack = function1.apply(context, itemStack);
// TODO: This cast is unsafe. Refactor in the future?
IPredicateFunction<ItemStackTemplate> function1 = (IPredicateFunction<ItemStackTemplate>) function;
itemStack = function1.apply(context, ItemStackTemplate.fromNonEmptyStack(itemStack)).create();
}
});
}
Expand Down