Skip to content

Re-point beta-fw tag on every beta publish#117

Merged
TrevorSchirmer merged 1 commit into
betafrom
fix/beta-fw-tag-target
Jul 23, 2026
Merged

Re-point beta-fw tag on every beta publish#117
TrevorSchirmer merged 1 commit into
betafrom
fix/beta-fw-tag-target

Conversation

@bharvey88

@bharvey88 bharvey88 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Version: 26.7.23.1 (unchanged, workflow only)

What does this implement/fix?

The rolling beta-fw release tag was stuck on the commit that was default-branch HEAD when the release was first created (gh release create without --target tags default-branch HEAD, and gh release upload never moves the tag). The published assets tracked every beta build while the release's source commit did not, so the release page and its source archives pointed at the wrong tree.

Adds a step to build-beta.yml that PATCHes the beta-fw tag ref to the built commit after each upload, so the tag always matches the assets. The stale tag was already re-pointed manually to current beta HEAD.

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Release Management
    • Beta firmware releases now consistently reference the exact commit used to build the published artifacts.
    • The beta release tag is automatically updated after new firmware assets are uploaded.

gh release create tagged default-branch HEAD once and uploads never
move the tag, so the release source commit drifted away from the
published assets. PATCH the tag ref to the built commit after upload.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@bharvey88 bharvey88 added the bugfix Bug fix label Jul 23, 2026
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 90e5c49c-440c-434c-b27e-e4a3a96f9b97

📥 Commits

Reviewing files that changed from the base of the PR and between e13fcf4 and c093926.

📒 Files selected for processing (1)
  • .github/workflows/build-beta.yml

Walkthrough

The beta firmware publish workflow now force-updates the beta-fw tag to the triggering commit after uploading firmware assets, then logs the resulting reference mapping.

Changes

Beta firmware publishing

Layer / File(s) Summary
Update beta firmware tag
.github/workflows/build-beta.yml
The publish job PATCHes GitHub’s beta-fw tag reference to ${{ github.sha }} after asset upload and echoes the response.

Estimated code review effort: 2 (Simple) | ~5 minutes

Poem

I’m a bunny with tags in a neat little row,
Watching beta commits hop where they should go.
Assets are uploaded, the ref follows through,
beta-fw now points to the commit that flew.
Hop, hop, publish—everything’s true!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states the main change: updating the beta-fw tag on each beta publish.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/beta-fw-tag-target

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@TrevorSchirmer
TrevorSchirmer merged commit 6092416 into beta Jul 23, 2026
11 checks passed
@TrevorSchirmer
TrevorSchirmer deleted the fix/beta-fw-tag-target branch July 23, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants