Skip to content

Remove unused current_volume global#57

Merged
bharvey88 merged 1 commit into
RemoveAnnounceVolfrom
cleanup/remove-current-volume
Jul 23, 2026
Merged

Remove unused current_volume global#57
bharvey88 merged 1 commit into
RemoveAnnounceVolfrom
cleanup/remove-current-volume

Conversation

@bharvey88

Copy link
Copy Markdown
Contributor

Version: 26.7.22.1

What does this implement/fix?

  • Follow-up to Remove Announce Volume #56: the volume restore removed there was the only reader of the current_volume global. This drops the now write-only global and its assignment in on_announcement.
  • Targets the RemoveAnnounceVol branch so it merges into Remove Announce Volume #56, not beta directly. No version bump for the same reason.

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

🤖 Generated with Claude Code

PR #56 removed the volume restore that was the only reader of
current_volume, leaving the global and its assignment in
on_announcement write-only. Drop both.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@bharvey88 bharvey88 added the bugfix Something isn't working label Jul 23, 2026
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • beta

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 33671e2d-eed2-4f5f-ae1f-ef4ae3b5ad66

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cleanup/remove-current-volume

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bharvey88
bharvey88 merged commit 632af8a into RemoveAnnounceVol Jul 23, 2026
8 checks passed
@bharvey88
bharvey88 deleted the cleanup/remove-current-volume branch July 23, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant