Skip to content

Cleanup: remove vestigial ble_firmware sub; fix build.yml device-name#101

Merged
bharvey88 merged 1 commit into
betafrom
cleanup/vestigial-ble-firmware
Jul 9, 2026
Merged

Cleanup: remove vestigial ble_firmware sub; fix build.yml device-name#101
bharvey88 merged 1 commit into
betafrom
cleanup/vestigial-ble-firmware

Conversation

@bharvey88

Copy link
Copy Markdown
Contributor

Version: 26.7.9.1 (no change — no-publish cleanup)

What does this implement/fix?

Small cleanup after the unified-firmware change (#100):

  • Remove the vestigial ble_firmware substitution. Nothing reads ${ble_firmware} anymore — the runtime "Bluetooth Proxy" switch replaced the old firmware_ble manifest selector, and the on-boot lambda that consumed it is gone. Removed from Core.yaml and MSR-1_BLE.yaml. Compiled output is identical.
  • Fix device-name in build.yml (msr-2msr-1). It's a required-but-unused input in the shared ApolloAutomation/Workflows build workflow (declared, never consumed), so this is a no-op correctness fix — the wrong value never affected any published path.

No firmware behavior change; does not publish.

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

🤖 Generated with Claude Code

The ble_firmware substitution is no longer read by anything after the
runtime Bluetooth Proxy switch replaced the firmware_ble manifest selector
(#100) - remove it from Core.yaml and MSR-1_BLE.yaml. Also correct the
copy-pasted device-name input in build.yml (msr-2 -> msr-1); it is a
required-but-unused input in the shared workflow, so this is a no-op
correctness fix.

No compiled-output change; does not publish.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@bharvey88, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 2 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3361ed53-4040-40c0-97a2-770a3e350d6a

📥 Commits

Reviewing files that changed from the base of the PR and between bd24876 and 502c4e7.

📒 Files selected for processing (3)
  • .github/workflows/build.yml
  • Integrations/ESPHome/Core.yaml
  • Integrations/ESPHome/MSR-1_BLE.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cleanup/vestigial-ble-firmware

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bharvey88
bharvey88 merged commit b46e1c5 into beta Jul 9, 2026
11 checks passed
@bharvey88
bharvey88 deleted the cleanup/vestigial-ble-firmware branch July 9, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant