Skip to content

Set http_request buffer_size_tx: 2048 - the real Out of buffer fix#95

Merged
bharvey88 merged 1 commit into
betafrom
fix-tx-buffer
Jul 8, 2026
Merged

Set http_request buffer_size_tx: 2048 - the real Out of buffer fix#95
bharvey88 merged 1 commit into
betafrom
fix-tx-buffer

Conversation

@bharvey88

Copy link
Copy Markdown
Contributor

Version: 26.7.8.8

What does this implement/fix?

Third time's the charm on HTTP_CLIENT: Out of buffer, and this one is confirmed against the IDF source rather than inferred: esp_http_client emits "Out of buffer" from request-line composition (http_client_prepare_first_line in esp_http_client.c) - GET <path>?<query> must fit buffer_size_tx. GitHub's release-asset redirect targets a signed URL with a ~850-character query string, so the follow-up request could never be built in the 512-byte default TX buffer. That's why the failure is at esp_http_client_open (before anything is sent), and why raising the RX buffer (#93, #94) didn't help - the error was reproduced unchanged on hardware running 26.7.8.7.

buffer_size_tx: 2048 on all images. The RX bump from #94 stays (the first hop's 3.6 KB CSP header is still real).

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

🤖 Generated with Claude Code

IDF's esp_http_client emits "Out of buffer" from request-line
composition: GET <path>?<query> must fit buffer_size_tx. GitHub's
release-asset redirect points at a signed URL with a ~850-char query
string, so the follow-up request could never be built in the 512-byte
default TX buffer - this is why esp_http_client_open failed, and why
raising the RX buffer (#93, #94) didn't help. Confirmed against the
IDF source (esp_http_client.c, http_client_prepare_first_line).

Version: 26.7.8.8

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@bharvey88, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 7 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 084067ab-9628-4e25-ac3b-81284ace9731

📥 Commits

Reviewing files that changed from the base of the PR and between b5a8de4 and 8ea86a8.

📒 Files selected for processing (4)
  • Integrations/ESPHome/Core.yaml
  • Integrations/ESPHome/MSR-1.yaml
  • Integrations/ESPHome/MSR-1_BLE.yaml
  • Integrations/ESPHome/MSR-1_Factory.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-tx-buffer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bharvey88
bharvey88 merged commit a798e0a into beta Jul 8, 2026
10 checks passed
@bharvey88
bharvey88 deleted the fix-tx-buffer branch July 8, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant