Render report PDFs inline when S3 stored them as binary - #214
Merged
Conversation
Watcher uploads of uppercase .PDF files often land as binary/octet-stream, so the report iframe downloaded the file instead of showing it. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ges. The MIME-type fix needs a package bump before a production tag; watcher/AGENTS.md keeps later branches from shipping src/ changes at the old version. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disposition=inline, which overrides a storedbinary/octet-streamtype so the browser renders the PDF instead of downloading it..PDF) and mark PDFs as inline on direct uploads.Test plan
*_Report.PDF(e.g. Azure Cielo) and confirm the Report Data iframe shows the PDF instead of triggering a download.Made with Cursor