Ap/sppid protid delim - #84
Draft
austinhpatton wants to merge 883 commits into
Draft
Conversation
…ent sized sequences Signed-off-by: Austin Patton <austin.patton@arcadiascience.com>
… or 25% of taxa. Signed-off-by: Austin Patton <austin.patton@arcadiascience.com>
Signed-off-by: Austin Patton <austin.patton@arcadiascience.com>
Signed-off-by: Austin Patton <austin.patton@arcadiascience.com>
Signed-off-by: Austin Patton <austin.patton@arcadiascience.com>
remove xref_tigrfam field
…ap/sppid_protid_delim
…, fail and print error if not
Collaborator
Author
|
Okay, so I've made a number of changes, and this now works as anticipated.
I've not yet added in a check at the onset of the workflow to make sure that the sequence headers are named properly, though I have included a check to make sure it's actually in the sequence IDs, and stop the workflow if it's not, printing a useful error message to output in this case. I think we can make these checks a fair bit more extensive, but doing something like this could be part of a larger effort to build in checks throughout the workflow. |
Signed-off-by: Austin Patton <austin.patton@arcadiascience.com>
Ap/fix schema
…ap/sppid_protid_delim
Signed-off-by: Austin Patton <austin.patton@arcadiascience.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay, so as we briefly discussed, this is a (relatively) simple change to use an updated naming convention for protein IDs, made to be consistent with the snakemake preprocessing workflow.
Old convention was:
Genus_species:proteinIDThe colon got replaced by an underscore by orthofinder, which made splitting the species and protein ID more challenging.
Now, the convention is:
Genus-species_proteinIDThe changes I implemented here basically just parameterize the delimiter, making
_the default, but splitting the two identifiers using the parameter value within the annotation module.I haven't actually tested it yet (hence the draft PR), but will make an updated version of the test dataset that follows this convention so that I can do so.