feat(cardinal): change command to use schema with proto wire by winton-library · Pull Request #899 · Argus-Labs/world-engine

winton-library · 2026-06-09T11:57:01Z

No description provided.

winton-library · 2026-06-09T11:57:16Z

feat(cardinal): change command to use schema with proto wire #899 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite/merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

…of the autogen code

codecov · 2026-06-11T09:19:58Z

❌ 4 Tests Failed:

Tests completed	Failed	Passed	Skipped
311	4	307	1

View the full list of 4 ❄️ flaky test(s)

github.com/argus-labs/world-engine/pkg/template/basic/shards/game::TestDST

Flake rate in main: 10.00% (Passed 9 times, Failed 1 times)

Stack Traces | 0s run time

=== RUN   TestDST
--- FAIL: TestDST (0.00s)
panic: error initializing system fields: failed to initialize field CreatePlayerCommands: command "create-player" has no registered codec (run the generator) [recovered, repanicked]

goroutine 8 [running]:
testing.tRunner.func1.2({0x1c1cb80, 0xc000390b70})
	.../hostedtoolcache/go/1.25.5.../src/testing/testing.go:1872 +0x237
testing.tRunner.func1()
	.../hostedtoolcache/go/1.25.5.../src/testing/testing.go:1875 +0x35b
panic({0x1c1cb80?, 0xc000390b70?})
	.../hostedtoolcache/go/1.25.5.../src/runtime/panic.go:783 +0x132
github..../world-engine/pkg/cardinal.RegisterSystem[...](0xc0003941e0, 0x1e4b280, {0x0, 0x0, 0x2125520})
	.../pkg/cardinal/system.go:39 +0x3dc
github..../basic/shards/game_test.registerSystems(0xc0003941e0)
	.../shards/game/main_test.go:43 +0x74
github..../basic/shards/game_test.TestDST.func1(0x212f868?)
	.../shards/game/main_test.go:14 +0x13
github..../world-engine/pkg/cardinal.newDSTFixture(0xc0000f2e00, {0x0?, 0xc00035f200?, 0x2b1b610?}, 0x1e4b2a0)
	.../pkg/cardinal/dst.go:207 +0x13a
github..../world-engine/pkg/cardinal.RunDST(0xc0000f2e00, 0x1e4b2a0, {0x0, 0x0, 0x4f8bd3?})
	.../pkg/cardinal/dst.go:60 +0x93
github..../basic/shards/game_test.TestDST(0xc0000f2e00?)
	.../shards/game/main_test.go:13 +0x25
testing.tRunner(0xc0000f2e00, 0x1e4b128)
	.../hostedtoolcache/go/1.25.5.../src/testing/testing.go:1934 +0xea
created by testing.(*T).Run in goroutine 1
	.../hostedtoolcache/go/1.25.5.../src/testing/testing.go:1997 +0x465

github.com/argus-labs/world-engine/pkg/template/multi-shard/shards/chat::TestDST

Flake rate in main: 10.00% (Passed 9 times, Failed 1 times)

Stack Traces | 0s run time

=== RUN   TestDST
--- FAIL: TestDST (0.00s)
panic: error initializing system fields: failed to initialize field UserChatCommands: command "user-chat" has no registered codec (run the generator) [recovered, repanicked]

goroutine 5 [running]:
testing.tRunner.func1.2({0x1c0cd80, 0xc0000d1920})
	.../hostedtoolcache/go/1.25.5.../src/testing/testing.go:1872 +0x237
testing.tRunner.func1()
	.../hostedtoolcache/go/1.25.5.../src/testing/testing.go:1875 +0x35b
panic({0x1c0cd80?, 0xc0000d1920?})
	.../hostedtoolcache/go/1.25.5.../src/runtime/panic.go:783 +0x132
github..../world-engine/pkg/cardinal.RegisterSystem[...](0xc00040e1e0, 0x1e33c50, {0x0, 0x0, 0xc0004099f0})
	.../pkg/cardinal/system.go:39 +0x3dc
github..../multi-shard/shards/chat_test.registerSystems(...)
	.../shards/chat/main_test.go:42
github..../multi-shard/shards/chat_test.TestDST.func1(0x2116f08?)
	.../shards/chat/main_test.go:14 +0x2c
github..../world-engine/pkg/cardinal.newDSTFixture(0xc000003c00, {0x0?, 0xc0000d00c0?, 0x2af49d8?}, 0x1e33c58)
	.../pkg/cardinal/dst.go:207 +0x13a
github..../world-engine/pkg/cardinal.RunDST(0xc000003c00, 0x1e33c58, {0x0, 0x0, 0x4f8bd3?})
	.../pkg/cardinal/dst.go:60 +0x93
github..../multi-shard/shards/chat_test.TestDST(0xc000003c00?)
	.../shards/chat/main_test.go:13 +0x25
testing.tRunner(0xc000003c00, 0x1e33b08)
	.../hostedtoolcache/go/1.25.5.../src/testing/testing.go:1934 +0xea
created by testing.(*T).Run in goroutine 1
	.../hostedtoolcache/go/1.25.5.../src/testing/testing.go:1997 +0x465

github.com/argus-labs/world-engine/pkg/template/multi-shard/shards/game::TestDST

Flake rate in main: 10.00% (Passed 9 times, Failed 1 times)

Stack Traces | 0s run time

=== RUN   TestDST
--- FAIL: TestDST (0.00s)
panic: error initializing system fields: failed to initialize field SpawnPlayerCommands: command "player-spawn" has no registered codec (run the generator) [recovered, repanicked]

goroutine 8 [running]:
testing.tRunner.func1.2({0x1c1d4c0, 0xc000410bd0})
	.../hostedtoolcache/go/1.25.5.../src/testing/testing.go:1872 +0x237
testing.tRunner.func1()
	.../hostedtoolcache/go/1.25.5.../src/testing/testing.go:1875 +0x35b
panic({0x1c1d4c0?, 0xc000410bd0?})
	.../hostedtoolcache/go/1.25.5.../src/runtime/panic.go:783 +0x132
github..../world-engine/pkg/cardinal.RegisterSystem[...](0xc0004141e0, 0x1e49ce0, {0x0, 0x0, 0x21242a0})
	.../pkg/cardinal/system.go:39 +0x3ce
github..../multi-shard/shards/game_test.registerSystems(0xc0004141e0)
	.../shards/game/main_test.go:43 +0x74
github..../multi-shard/shards/game_test.TestDST.func1(0x212e5e8?)
	.../shards/game/main_test.go:14 +0x13
github..../world-engine/pkg/cardinal.newDSTFixture(0xc0000f2e00, {0x0?, 0xc0003df230?, 0x2b1db70?}, 0x1e49ce8)
	.../pkg/cardinal/dst.go:207 +0x13a
github..../world-engine/pkg/cardinal.RunDST(0xc0000f2e00, 0x1e49ce8, {0x0, 0x0, 0x4f8bd3?})
	.../pkg/cardinal/dst.go:60 +0x93
github..../multi-shard/shards/game_test.TestDST(0xc0000f2e00?)
	.../shards/game/main_test.go:13 +0x25
testing.tRunner(0xc0000f2e00, 0x1e49b78)
	.../hostedtoolcache/go/1.25.5.../src/testing/testing.go:1934 +0xea
created by testing.(*T).Run in goroutine 1
	.../hostedtoolcache/go/1.25.5.../src/testing/testing.go:1997 +0x465

github.com/argus-labs/world-engine/pkg/template/multi-shard::TestDSTGame

Flake rate in main: 10.00% (Passed 9 times, Failed 1 times)

Stack Traces | 0s run time

=== RUN   TestDSTGame
--- FAIL: TestDSTGame (0.00s)
panic: error initializing system fields: failed to initialize field SpawnPlayerCommands: command "player-spawn" has no registered codec (run the generator) [recovered, repanicked]

goroutine 8 [running]:
testing.tRunner.func1.2({0x17c9a60, 0xc00038cb70})
	.../hostedtoolcache/go/1.25.5.../src/testing/testing.go:1872 +0x237
testing.tRunner.func1()
	.../hostedtoolcache/go/1.25.5.../src/testing/testing.go:1875 +0x35b
panic({0x17c9a60?, 0xc00038cb70?})
	.../hostedtoolcache/go/1.25.5.../src/runtime/panic.go:783 +0x132
github..../world-engine/pkg/cardinal.RegisterSystem[...](0xc00039e1e0, 0x198ee50, {0x0, 0x0, 0x0})
	.../pkg/cardinal/system.go:39 +0x3ce
github..../pkg/template/multi-shard_test.TestDSTGame.func1(0xc00039e1e0)
	.../template/multi-shard/dst_game_test.go:14 +0x74
github..../world-engine/pkg/cardinal.newDSTFixture(0xc0000e2e00, {0x0?, 0xc00038c1e0?, 0x24332d8?}, 0x198ee60)
	.../pkg/cardinal/dst.go:207 +0x13a
github..../world-engine/pkg/cardinal.RunDST(0xc0000e2e00, 0x198ee60, {0x0, 0x0, 0x4f8533?})
	.../pkg/cardinal/dst.go:60 +0x93
github..../pkg/template/multi-shard_test.TestDSTGame(0xc0000e2e00?)
	.../template/multi-shard/dst_game_test.go:12 +0x25
testing.tRunner(0xc0000e2e00, 0x198ece8)
	.../hostedtoolcache/go/1.25.5.../src/testing/testing.go:1934 +0xea
created by testing.(*T).Run in goroutine 1
	.../hostedtoolcache/go/1.25.5.../src/testing/testing.go:1997 +0x465

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

rmrt1n · 2026-06-22T08:31:53Z

lgtm

feat(cardinal): change command to use schema with proto wire

498db2b

refactor(cardinal,lobby): generate lobby proto command and first PoC …

067618c

…of the autogen code

winton-library added 5 commits June 12, 2026 18:53

refactor(plugin): adjust the command generation with adr-056

d879393

refactor(cardinal): remove hard validation on proto for required message

efd5597

chore(dep): bump up the telemetry version to match monorepo

fac7f7e

feat(cardinal): remove validation for required

1d122e3

chore(cardinal,lobby): fix ci lint

b4b0fd6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cardinal): change command to use schema with proto wire#899

feat(cardinal): change command to use schema with proto wire#899
winton-library wants to merge 7 commits into
mainfrom
winton/adr-056

winton-library commented Jun 9, 2026

Uh oh!

winton-library commented Jun 9, 2026

Uh oh!

codecov Bot commented Jun 11, 2026 •

edited

Loading

Uh oh!

rmrt1n commented Jun 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

winton-library commented Jun 9, 2026

Uh oh!

winton-library commented Jun 9, 2026

How to use the Graphite Merge Queue

Uh oh!

codecov Bot commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 4 Tests Failed:

Uh oh!

rmrt1n commented Jun 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Jun 11, 2026 •

edited

Loading