Skip to content

feat(cases): add inline edit and delete actions #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Lint111 wants to merge 1 commit into
base: master
Choose a base branch
from
+269 −43
Draft

feat(cases): add inline edit and delete actions #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 96 additions & 29 deletions src/web/public/session-ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,17 +161,37 @@ Object.assign(CodemanApp.prototype, {
const selected = option.name === selectedName;
const id = `quickStartCaseOption-${index}`;
return `
<button
type="button"
id="${id}"
class="case-combobox-option ${active ? 'active' : ''} ${selected ? 'selected' : ''}"
role="option"
aria-selected="${selected ? 'true' : 'false'}"
data-case="${escapeHtml(option.name)}"
title="${escapeHtml(option.label)}">
<span class="case-combobox-check">${selected ? '✓' : ''}</span>
<span class="case-combobox-option-label">${escapeHtml(option.label)}</span>
</button>
<div class="case-combobox-row" data-case="${escapeHtml(option.name)}">
<button
type="button"
id="${id}"
class="case-combobox-option ${active ? 'active' : ''} ${selected ? 'selected' : ''}"
role="option"
aria-selected="${selected ? 'true' : 'false'}"
data-case="${escapeHtml(option.name)}"
title="${escapeHtml(option.label)}">
<span class="case-combobox-check">${selected ? '✓' : ''}</span>
<span class="case-combobox-option-label">${escapeHtml(option.label)}</span>
</button>
<span class="case-combobox-actions">
<button type="button" class="case-combobox-action" data-case-action="edit"
title="Edit case settings" aria-label="Edit ${escapeHtml(option.label)} settings">
<svg viewBox="0 0 24 24" aria-hidden="true">
<path d="M12 20h9"/>
<path d="M16.5 3.5a2.1 2.1 0 0 1 3 3L8 18l-4 1 1-4Z"/>
</svg>
</button>
<button type="button" class="case-combobox-action case-combobox-action-delete"
data-case-action="delete" title="Delete case"
aria-label="Delete ${escapeHtml(option.label)}">
<svg viewBox="0 0 24 24" aria-hidden="true">
<path d="M3 6h18"/>
<path d="M8 6V4h8v2"/>
<path d="M19 6l-1 14H6L5 6"/>
</svg>
</button>
</span>
</div>
`;
})
.join('');
Expand Down Expand Up @@ -238,6 +258,20 @@ Object.assign(CodemanApp.prototype, {
});
list.addEventListener('mousedown', event => event.preventDefault());
list.addEventListener('click', event => {
const action = event.target.closest?.('[data-case-action]');
if (action) {
event.preventDefault();
event.stopPropagation();
const caseName = action.closest('.case-combobox-row')?.dataset?.case;
if (!caseName) return;
if (action.dataset.caseAction === 'edit') {
this.editCaseFromPicker(caseName);
} else if (action.dataset.caseAction === 'delete') {
this.closeCasePicker();
this.deleteCase(caseName);
}
return;
}
const option = event.target.closest?.('.case-combobox-option');
if (option?.dataset?.case) {
this.selectQuickStartCase(option.dataset.case);
Expand Down Expand Up @@ -1637,6 +1671,23 @@ Object.assign(CodemanApp.prototype, {
if (desktopOpusCheckbox) desktopOpusCheckbox.checked = settings.opusContext1m;
},

editCaseFromPicker(caseName, mobile = false) {
this.selectQuickStartCase(caseName);
if (mobile) this.closeMobileCasePicker();

const popover = document.getElementById(
mobile ? 'caseSettingsPopoverMobile' : 'caseSettingsPopover'
);
// Force the existing toggle onto its open path even if another case's
// settings popover was already visible.
popover?.classList.add('hidden');
if (mobile) {
this.toggleCaseSettingsMobile();
} else {
this.toggleCaseSettings();
}
},

// ═══════════════════════════════════════════════════════════════
// Create Case Modal
// ═══════════════════════════════════════════════════════════════
Expand Down Expand Up @@ -2441,25 +2492,41 @@ Object.assign(CodemanApp.prototype, {
for (const c of allCases) {
const isSelected = c.name === currentCase;
html += `
<button class="mobile-case-item ${isSelected ? 'selected' : ''}"
onclick="app.selectMobileCase(${escapeHtml(JSON.stringify(c.name))})">
<span class="mobile-case-item-icon">
<svg width="18" height="18" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2">
<path d="M22 19a2 2 0 0 1-2 2H4a2 2 0 0 1-2-2V5a2 2 0 0 1 2-2h5l2 3h9a2 2 0 0 1 2 2z"/>
</svg>
</span>
<span class="mobile-case-item-name">${escapeHtml(c.label)}</span>
<span class="mobile-case-item-delete" onclick="event.stopPropagation(); app.deleteCaseMobile(${escapeHtml(JSON.stringify(c.name))})" title="Delete">
<svg width="16" height="16" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2">
<line x1="18" y1="6" x2="6" y2="18"/><line x1="6" y1="6" x2="18" y2="18"/>
</svg>
</span>
<span class="mobile-case-item-check">
<svg width="18" height="18" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2.5">
<polyline points="20 6 9 17 4 12"/>
</svg>
<div class="mobile-case-item ${isSelected ? 'selected' : ''}">
<button type="button" class="mobile-case-item-select"
onclick="app.selectMobileCase(${escapeHtml(JSON.stringify(c.name))})">
<span class="mobile-case-item-icon">
<svg width="18" height="18" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2">
<path d="M22 19a2 2 0 0 1-2 2H4a2 2 0 0 1-2-2V5a2 2 0 0 1 2-2h5l2 3h9a2 2 0 0 1 2 2z"/>
</svg>
</span>
<span class="mobile-case-item-name">${escapeHtml(c.label)}</span>
<span class="mobile-case-item-check">
<svg width="18" height="18" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2.5">
<polyline points="20 6 9 17 4 12"/>
</svg>
</span>
</button>
<span class="mobile-case-item-actions">
<button type="button" class="mobile-case-item-action mobile-case-item-edit"
onclick="app.editCaseFromPicker(${escapeHtml(JSON.stringify(c.name))}, true)"
title="Edit case settings" aria-label="Edit ${escapeHtml(c.label)} settings">
<svg viewBox="0 0 24 24" aria-hidden="true">
<path d="M12 20h9"/>
<path d="M16.5 3.5a2.1 2.1 0 0 1 3 3L8 18l-4 1 1-4Z"/>
</svg>
</button>
<button type="button" class="mobile-case-item-action mobile-case-item-delete"
onclick="app.deleteCaseMobile(${escapeHtml(JSON.stringify(c.name))})"
title="Delete case" aria-label="Delete ${escapeHtml(c.label)}">
<svg viewBox="0 0 24 24" aria-hidden="true">
<path d="M3 6h18"/>
<path d="M8 6V4h8v2"/>
<path d="M19 6l-1 14H6L5 6"/>
</svg>
</button>
</span>
</button>
</div>
`;
}

Expand Down
122 changes: 109 additions & 13 deletions src/web/public/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4053,13 +4053,21 @@ body.touch-device .terminal-container .xterm .xterm-helper-textarea {
display: none;
}

.case-combobox-row {
position: relative;
display: flex;
align-items: center;
}

.case-combobox-option {
display: grid;
grid-template-columns: 18px minmax(0, 1fr);
align-items: center;
flex: 1;
min-width: 0;
width: 100%;
min-height: 34px;
padding: 0.35rem 0.45rem;
padding: 0.35rem 4.2rem 0.35rem 0.45rem;
background: transparent;
border: 1px solid transparent;
border-radius: 6px;
Expand Down Expand Up @@ -4093,6 +4101,58 @@ body.touch-device .terminal-container .xterm .xterm-helper-textarea {
white-space: nowrap;
}

.case-combobox-actions {
position: absolute;
right: 0.3rem;
display: flex;
gap: 0.15rem;
opacity: 0;
pointer-events: none;
transition: opacity var(--transition-smooth);
}

.case-combobox-row:hover .case-combobox-actions,
.case-combobox-row:focus-within .case-combobox-actions {
opacity: 1;
pointer-events: auto;
}

.case-combobox-action {
display: inline-flex;
width: 28px;
height: 28px;
padding: 0;
align-items: center;
justify-content: center;
color: var(--text-dim);
background: #242a34;
border: 1px solid rgba(255, 255, 255, 0.12);
border-radius: 4px;
cursor: pointer;
}

.case-combobox-action:hover,
.case-combobox-action:focus-visible {
color: var(--text);
background: #303846;
}

.case-combobox-action-delete:hover,
.case-combobox-action-delete:focus-visible {
color: #f87171;
border-color: rgba(248, 113, 113, 0.45);
}

.case-combobox-action svg {
width: 14px;
height: 14px;
fill: none;
stroke: currentColor;
stroke-width: 2;
stroke-linecap: round;
stroke-linejoin: round;
}

.case-combobox-empty {
padding: 0.85rem 0.75rem;
color: var(--text-muted);
Expand Down Expand Up @@ -5059,23 +5119,20 @@ body.touch-device .terminal-container .xterm .xterm-helper-textarea {
.mobile-case-item {
display: flex;
align-items: center;
gap: 12px;
padding: 14px 20px;
padding: 4px 8px;
background: transparent;
border: none;
color: #e5e5e5;
font-size: 0.95rem;
text-align: left;
cursor: pointer;
transition: background 0.1s;
width: 100%;
}

.mobile-case-item:hover {
.mobile-case-item:hover,
.mobile-case-item:focus-within {
background: rgba(255, 255, 255, 0.05);
}

.mobile-case-item:active {
.mobile-case-item:has(.mobile-case-item-select:active) {
background: rgba(255, 255, 255, 0.1);
}

Expand All @@ -5084,6 +5141,23 @@ body.touch-device .terminal-container .xterm .xterm-helper-textarea {
color: #22c55e;
}

.mobile-case-item-select {
display: flex;
min-width: 0;
min-height: 44px;
padding: 8px 4px 8px 12px;
align-items: center;
flex: 1;
gap: 12px;
color: inherit;
background: transparent;
border: 0;
font: inherit;
font-size: 0.95rem;
text-align: left;
cursor: pointer;
}

.mobile-case-item-icon {
width: 20px;
height: 20px;
Expand Down Expand Up @@ -5120,21 +5194,43 @@ body.touch-device .terminal-container .xterm .xterm-helper-textarea {
opacity: 1;
}

.mobile-case-item-delete {
width: 28px;
height: 28px;
.mobile-case-item-actions {
display: flex;
flex-shrink: 0;
gap: 4px;
}

.mobile-case-item-action {
width: 36px;
height: 36px;
padding: 0;
display: flex;
align-items: center;
justify-content: center;
color: var(--text-dim);
opacity: 0.4;
flex-shrink: 0;
background: rgba(255, 255, 255, 0.04);
border: 1px solid rgba(255, 255, 255, 0.1);
border-radius: 4px;
transition: all var(--transition-smooth);
}

.mobile-case-item-action svg {
width: 16px;
height: 16px;
fill: none;
stroke: currentColor;
stroke-width: 2;
stroke-linecap: round;
stroke-linejoin: round;
}

.mobile-case-item-edit:active {
color: #93c5fd;
background: rgba(59, 130, 246, 0.15);
}

.mobile-case-item-delete:active {
opacity: 1;
color: #ef4444;
background: rgba(239, 68, 68, 0.15);
}
Expand Down
Loading