Skip to content

workflows: replace softprops/action-gh-release with gh CLI (v22.21.1-profiler) #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
harshita-gupta wants to merge 1 commit into
base: v22.21.1-profiler
Choose a base branch
from
+124 −20
Draft

workflows: replace softprops/action-gh-release with gh CLI (v22.21.1-profiler) #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 29 additions & 5 deletions .github/workflows/build-node-fibers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:

env:
NODE_VERSION: v22.21.1
REPO: ${{ github.repository }}

steps:
- name: Checkout repository
Expand Down Expand Up @@ -65,10 +66,33 @@ jobs:
tar -czf "$ARCHIVE_NAME" -C "$(dirname "$FIBERS_DIR")" "$(basename "$FIBERS_DIR")"

- name: Upload archive to release
uses: softprops/action-gh-release@v1
with:
name: node-${{ env.NODE_VERSION }}-LATEST
tag_name: node-${{ env.NODE_VERSION }}-release
files: ${{ env.ARCHIVE_NAME }}
# Attach the built node-fibers archive to the same node-${NODE_VERSION}-release
# release that hosts the corresponding Node binaries.
#
# Normally this workflow runs after Build Node via workflow_run, so the
# release already exists by the time we get here. But workflow_dispatch can
# fire it independently (release may not yet exist), and the matrix still
# runs both arms (linux-x64, linux-arm64) in parallel — so both arms can
# race to create the release. The view-or-create guard with the trailing
# `|| gh release view` tolerates "already exists" from a losing racer and
# propagates any other create failure through the final view.
#
# `--clobber` makes re-uploads idempotent on asset name collisions by
# deleting the existing asset before uploading. If the new upload fails
# after the delete, just re-run the job to rebuild.
#
# `gh release edit --title` after upload keeps the release title
# deterministically derived from NODE_VERSION, overriding any manual rename
# in the GitHub UI.
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
set -euo pipefail
TAG="node-${NODE_VERSION}-release"
RELEASE_NAME="node-${NODE_VERSION}-LATEST"
if ! gh release view "$TAG" --repo "$REPO" >/dev/null 2>&1; then
gh release create "$TAG" --title "$RELEASE_NAME" --notes "" --repo "$REPO" \
|| gh release view "$TAG" --repo "$REPO" >/dev/null
fi
gh release upload "$TAG" "$ARCHIVE_NAME" --clobber --repo "$REPO"
gh release edit "$TAG" --title "$RELEASE_NAME" --repo "$REPO"
38 changes: 33 additions & 5 deletions .github/workflows/build-node-openssl-fips.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ jobs:
runs_on: ubuntu-22.04-arm
runs-on: ${{ matrix.runs_on }}

env:
REPO: ${{ github.repository }}

steps:
- name: Checkout Node fork
uses: actions/checkout@v3
Expand Down Expand Up @@ -89,10 +92,35 @@ jobs:
path: artifacts/${{ env.NODE_ARCHIVE_LATEST }}

- name: Upload Node archive to release
uses: softprops/action-gh-release@v1
with:
name: node-${{ env.NODE_VERSION }}-fips-LATEST
tag_name: node-${{ env.NODE_VERSION }}-fips-release
files: ./artifacts/${{ env.NODE_ARCHIVE_LATEST }}
# Publish the FIPS Node build to its own release tag
# (node-${NODE_VERSION}-fips-release), separate from the default Node
# release so consumers can select the FIPS variant explicitly rather than
# relying on filename conventions inside a shared release.
#
# This workflow is workflow_dispatch-only, and the matrix has two arms
# (linux-x64, linux-arm64) running in parallel — on the first invocation
# for a new NODE_VERSION both arms race to create the release. The
# view-or-create guard with the trailing `|| gh release view` tolerates
# "already exists" from the losing racer and propagates any other create
# failure through the final view.
#
# `--clobber` makes re-uploads idempotent on asset name collisions by
# deleting the existing asset before uploading. If the new upload fails
# after the delete, just re-run the job.
#
# `gh release edit --title` after upload keeps the release title
# deterministically derived from NODE_VERSION, overriding any manual
# rename in the GitHub UI.
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
set -euo pipefail
TAG="node-${NODE_VERSION}-fips-release"
RELEASE_NAME="node-${NODE_VERSION}-fips-LATEST"
FILE="./artifacts/${NODE_ARCHIVE_LATEST}"
if ! gh release view "$TAG" --repo "$REPO" >/dev/null 2>&1; then
gh release create "$TAG" --title "$RELEASE_NAME" --notes "" --repo "$REPO" \
|| gh release view "$TAG" --repo "$REPO" >/dev/null
fi
gh release upload "$TAG" "$FILE" --clobber --repo "$REPO"
gh release edit "$TAG" --title "$RELEASE_NAME" --repo "$REPO"
35 changes: 30 additions & 5 deletions .github/workflows/build-node-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:

env:
NODE_VERSION: v22.21.1
REPO: ${{ github.repository }}

steps:
- name: Checkout repository
Expand Down Expand Up @@ -68,10 +69,34 @@ jobs:
tar --hard-dereference -cvzf packages_${{matrix.arch}}.tar.gz bcrypt@5.1.0 cld@2.9.1 unix-dgram@2.0.6 "@datadog+pprof@5.8.0"

- name: Upload archive to release
uses: softprops/action-gh-release@v1
with:
name: node-${{ env.NODE_VERSION }}-LATEST
tag_name: node-${{ env.NODE_VERSION }}-release
files: packages_${{matrix.arch}}.tar.gz
# Attach the built gyp-package bundle to the same node-${NODE_VERSION}-release
# release that hosts the corresponding Node binaries.
#
# Normally this workflow runs after Build Node via workflow_run, so the
# release already exists by the time we get here. But workflow_dispatch can
# fire it independently (release may not yet exist), and the matrix still
# runs both arms (linux-x64, linux-arm64) in parallel — so both arms can
# race to create the release. The view-or-create guard with the trailing
# `|| gh release view` tolerates "already exists" from a losing racer and
# propagates any other create failure through the final view.
#
# `--clobber` makes re-uploads idempotent on asset name collisions by
# deleting the existing asset before uploading. If the new upload fails
# after the delete, just re-run the job.
#
# `gh release edit --title` after upload keeps the release title
# deterministically derived from NODE_VERSION, overriding any manual rename
# in the GitHub UI.
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
set -euo pipefail
TAG="node-${NODE_VERSION}-release"
RELEASE_NAME="node-${NODE_VERSION}-LATEST"
FILE="packages_${{matrix.arch}}.tar.gz"
if ! gh release view "$TAG" --repo "$REPO" >/dev/null 2>&1; then
gh release create "$TAG" --title "$RELEASE_NAME" --notes "" --repo "$REPO" \
|| gh release view "$TAG" --repo "$REPO" >/dev/null
fi
gh release upload "$TAG" "$FILE" --clobber --repo "$REPO"
gh release edit "$TAG" --title "$RELEASE_NAME" --repo "$REPO"
37 changes: 32 additions & 5 deletions .github/workflows/build-node.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
env:
S3_BUCKET: your-bucket-name
AWS_REGION: us-east-1
REPO: ${{ github.repository }}

steps:
- name: Checkout Node fork
Expand Down Expand Up @@ -82,10 +83,36 @@ jobs:
path: artifacts/${{ env.NODE_ARCHIVE_LATEST }}

- name: Upload Node archive to release
uses: softprops/action-gh-release@v1
with:
name: node-${{ env.NODE_VERSION }}-LATEST
tag_name: node-${{ env.NODE_VERSION }}-release
files: ./artifacts/${{ env.NODE_ARCHIVE_LATEST }}
# Publish the built Node archive to the node-${NODE_VERSION}-release release.
# This is the first uploader in the pipeline; build-node-packages and
# build-node-fibers attach additional artifacts to the same release later.
#
# Matrix concurrency: both matrix arms (linux-x64, linux-arm64) hit this step
# in parallel. On the first run for a new NODE_VERSION the release does not
# yet exist, so both arms race to create it. The view-or-create guard with
# the trailing `|| gh release view` tolerates "already exists" from the
# losing arm (as long as the release now exists); any other create failure
# propagates through that second view.
#
# `--clobber` makes re-uploads idempotent on asset name collisions: an
# existing asset with the same name is deleted before the new one uploads.
# Acceptable here because the -LATEST assets are always reproducible from
# the build inputs; if the upload fails after the delete, just re-run the
# job.
#
# `gh release edit --title` after upload keeps the release title
# deterministically derived from NODE_VERSION even if someone renames the
# release in the GitHub UI.
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
set -euo pipefail
TAG="node-${NODE_VERSION}-release"
RELEASE_NAME="node-${NODE_VERSION}-LATEST"
FILE="./artifacts/${NODE_ARCHIVE_LATEST}"
if ! gh release view "$TAG" --repo "$REPO" >/dev/null 2>&1; then
gh release create "$TAG" --title "$RELEASE_NAME" --notes "" --repo "$REPO" \
|| gh release view "$TAG" --repo "$REPO" >/dev/null
fi
gh release upload "$TAG" "$FILE" --clobber --repo "$REPO"
gh release edit "$TAG" --title "$RELEASE_NAME" --repo "$REPO"
Loading