[chore] Optimize config descriptions for better understanding#109
Merged
Conversation
CLA Signature Pass0oshowero0, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves YAML configuration comments in transfer_queue/config.yaml and scripts/performance_test/perftest_config.yaml to make field descriptions clearer and more informative. It also relocates the empty RayStore: section after Yuanrong in both files.
Changes:
- Reworded comments for
metrics.port,SimpleStorage,MooncakeStore, andYuanrongfields to be more descriptive and self-explanatory. - Added a warning note on
MooncakeStore.auto_initregarding termination of existingmooncake_masterprocesses. - Moved the (empty)
RayStore:block to the bottom of thebackend:section.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| transfer_queue/config.yaml | Improved comment wording for backend config fields; relocated RayStore: section. |
| scripts/performance_test/perftest_config.yaml | Mirror documentation improvements; relocated RayStore: section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title