v0.18.0 — sound banks from portal-curated playlists - #16
Merged
Conversation
createSoundBank now accepts a playlist_id instead of seeds. Slots become pools, so the sounds a game plays can change without shipping code. Slots are used exactly as curated — no similarity expansion. Whoever built the bank already chose what belongs in each slot, and quietly adding sounds they never listened to is the same mistake as auto-refreshing their gunshot. Widening a slot is a decision made in the portal, where it can be heard first. Adds kind/sound_count/slots to PlaylistInfo and a sounds list to PlaylistResult, kept separate from tracks so neither needs a type test before use. Verified end to end through Open Cloud against the live API: 27 steps green, including a two-slot bank whose pools match the playlist's declared slots exactly.
this-fifo
temporarily deployed
to
openCloud-smoke
July 28, 2026 18:15 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createSoundBankcan now take aplaylist_idinstead ofseeds. Slots curated in the portal become pools, so the sounds a game plays can change without shipping code.The design call
Slots are used exactly as curated — no similarity expansion at runtime. Whoever built the bank already decided what belongs in each slot, and quietly adding sounds they never listened to is the same mistake as swapping a game's gunshot unasked. Widening a slot is a decision made in the portal, where it can be heard first.
bank.Pools[name].sourcereads"playlist"on this path.Everything downstream is unchanged:
pickstill avoids immediate repeats, andreportUnavailablestill drops a sound that fails to load.Types
getPlaylistnow understands playlists carrying sound effects —playlist.kind(music/sfx/mixed),playlist.slots, and asoundslist besidetracks. Kept separate rather than unioned intotracksso neither list needs a type test before use, which strict-mode Luau makes genuinely painful.Sounds carry the same shape as
sfxSearchresults includingsound_start_sec/sound_end_sec— trimming tosound_start_secremoves the leading silence that makes an impact feel late.seedsis now optional. Passseedsorplaylist_id, not both.Verification
soundBank.spec.luau— playlist pools, picking, and the failure paths (a 404 playlist, a music playlist with no slots, both rejected rather than resolving to an empty bank that picksnilat runtime). 21 specs pass.getPlaylist (sfx)asserts slots account for every sound;createSoundBank (from playlist)asserts the resolved pools match the declared slots index for index. 27/27 green against the live API through a real Roblox engine.stylua,selene, andluau-lsp analyzeclean.The server side is already deployed, so the smoke ran against the real endpoint rather than a staging shim.