feat: show all search filters on the All tab (web + mobile)#14248
Draft
dylanjeffers wants to merge 1 commit intomainfrom
Draft
feat: show all search filters on the All tab (web + mobile)#14248dylanjeffers wants to merge 1 commit intomainfrom
dylanjeffers wants to merge 1 commit intomainfrom
Conversation
Previously the All tab had no filter buttons even though the underlying search-all query already accepts every filter. The Tracks/Albums/Playlists sub-tabs each exposed their relevant subset, so filtering was only available after switching tabs. The All tab now exposes the union of all sub-tab filters: genre, mood, key, bpm, isPremium, hasDownloads, isVerified. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Contributor
🌐 Web preview readyPreview URL: https://audius-web-preview-pr-14248.audius.workers.dev Unique preview for this PR (deployed from this branch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allentry in the categories/filters mapping (packages/web/src/pages/search-page/categories.tsandpackages/mobile/src/screens/search-screen/SearchCategoriesAndFilters.tsx) from an empty list to the union of sub-tab filters. The filters were already wired throughuseSearchAllResultsinpackages/common/src/api/tan-query/search/useSearchResults.ts, so no API plumbing was needed.Test plan
npm run web:prod, navigate to/search, confirm the All tab shows all 7 filter buttons in the header bottom barPodcasts, key + bpm filters are hidden (existing behavior)🤖 Generated with Claude Code