[Mobile] Use skeleton placeholders on notifications screen#14279
Merged
dylanjeffers merged 1 commit intomainfrom May 8, 2026
Merged
[Mobile] Use skeleton placeholders on notifications screen#14279dylanjeffers merged 1 commit intomainfrom
dylanjeffers merged 1 commit intomainfrom
Conversation
Replaces the footer spinner on the mobile notifications screen with skeleton notification rows that mirror the shape of real notifications, matching the loading pattern used by the new lineup system. Skeletons appear during the initial fetch and while paginating; empty and error states are preserved. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LineupTileSkeletoninTrackLineup): skeletons render during initial fetch and during pagination, mixed into the sameFlashListdata array.EmptyNotifications) and error states are preserved — skeletons are suppressed whenisErroris true, and the empty-state branch is unchanged.Files
packages/mobile/src/screens/notifications-screen/NotificationListItemSkeleton.tsx— new skeleton row mirroring theNotificationTilelayout (icon + profile picture row + 2 text lines + timestamp placeholder).packages/mobile/src/screens/notifications-screen/NotificationList.tsx— interleavesLoadingItemplaceholders into the FlashList data; drops the footer spinner.Test plan
EmptyNotificationswhen there are no notifications.🤖 Generated with Claude Code