fix(tests+docs): reconcile with merged streaming rewrites - #29
Merged
Conversation
The streaming code was rewritten upstream (no AbortSignal.timeout on stream
fetches, client-disconnect handling via res.on('close')/res.destroyed,
run.completed.summary streamed word-by-word, thinking at 10ms/word, synthetic
'error' events persisted). Align tests, docs, and diagrams:
- Tests: give the mock Response on/off/destroyed so readAgentStream's
disconnect wiring runs; add coverage for run.completed summary streaming and
the error-event merge on mid-stream failure. 108 tests, messages.service 96%,
overall line coverage 87%.
- Docs: update DOCUMENTATION.md (streaming proxy, handleEvent, event union incl.
'error' + run.completed.summary, timeout semantics) and TESTING.md numbers.
- Diagrams: update flow_handle_event, flow_send_message, and the event class
diagrams; re-render PNGs.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The streaming code was rewritten upstream (no AbortSignal.timeout on stream fetches, client-disconnect handling via res.on('close')/res.destroyed, run.completed.summary streamed word-by-word, thinking at 10ms/word, synthetic 'error' events persisted). Align tests, docs, and diagrams: