fix: support OpenHands and Factory Droid transcript bundles - #121
Open
volfiros wants to merge 3 commits into
Open
fix: support OpenHands and Factory Droid transcript bundles#121volfiros wants to merge 3 commits into
volfiros wants to merge 3 commits into
Conversation
Contributor
Author
|
@kushalpatil07 can you review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
greplica transcript bundlealready has platform transcript loaders for OpenHands and Factory Droid, but the CLI parser only acceptscodex,claude,copilot, andopencode.That means valid OpenHands and Factory Droid transcripts are rejected before the existing projection code can run. OpenHands has an additional usability gap: event directories do not provide a bundle-level session reference unless Greplica derives one from the conversation path or event metadata.
While verifying this change,
npm run buildwas also blocked on currentmainby the existing OpenCodeHookInputimport break. I fixed that blocker in this PR so the transcript bundle change could be built and tested end-to-end.Changes
openhandsandfactory-droidingreplica transcript bundle --platformvalidation and help text.sessionIdFromTranscriptPathfallback for transcript formats that do not always include session metadata in the filtered transcript.~/.openhands/conversations/<conversationId>/eventspaths.session_id/ conversation ID andcwd/working_dirwhen those fields are present in events.HookInputtype import build blocker using the same minimal approach as fix: import HookInput type from types.ts in opencode installer #110 and fix: import HookInput from hooks/types after #95 refactor #112.Verification
Additional focused repro checks were run against temporary fixtures:
The repro checks verified that:
--platform openhandsaccepts an OpenHandseventsdirectory.session_ref: openhands-session:<conversationId>from the events path when event metadata is missing.conversation_idis present.cwdfromworking_dirmetadata.--platform factory-droidaccepts Claude-style JSONL transcripts.session_ref: factory-droid-session:<sessionId>.Resolves #120