fix(hooks): C2 failure trails + C3 GREPLICA_HOME pin (#145) - #174
Open
aadivyaraushan wants to merge 7 commits into
Open
fix(hooks): C2 failure trails + C3 GREPLICA_HOME pin (#145)#174aadivyaraushan wants to merge 7 commits into
aadivyaraushan wants to merge 7 commits into
Conversation
…ags (C1/C4/C6) Part C correctness from Autoloops#145: fail closed on incomplete embedBatch results, resolve default branch via ls-remote or unknown, and neutralize early-close tags in working-memory prompts so pasted transcript content cannot break the evidence fence. Co-authored-by: Cursor <cursoragent@cursor.com>
Log hook-worker failures to JSONL and retain run artifacts; resolve and pin GREPLICA_HOME into child env and surface it in doctor. Co-authored-by: Cursor <cursoragent@cursor.com>
Add a 5s timeout on ls-remote, reuse/rename the existing main scope when default_branch changes, and reject wrong-length embedding vectors in tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Print Greplica home before context resolution, cap hook-worker.jsonl, and delay OS temp runDir removal after retain so spawn close handlers cannot race. Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve worker.ts and package.json conflicts so transcript escape, hook failure trails, GREPLICA_HOME pin, and all related check scripts coexist. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep the worker alive briefly after retain so OS temp dirs are actually removed, and note that logs/runs may contain sensitive agent output. Co-authored-by: Cursor <cursoragent@cursor.com>
Document that logs/runs and hook-worker.jsonl may contain agent output. Co-authored-by: Cursor <cursoragent@cursor.com>
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part C correctness/runtime fixes from #145:
$GREPLICA_HOME/logs/hook-worker.jsonl, and run artifacts are retained under$GREPLICA_HOME/logs/runs/(last 20). Successful updates still clean up the temp run dir.resolveGreplicaHome()reports path + source (GREPLICA_HOME|ENGINEERING_CONTEXT_HOME|default). Hook worker / agent spawn env pinsGREPLICA_HOMEto the parent-resolved path.greplica doctorprints the active home path and source before Database/Config.Skips C5 (owned by #108). Does not include C1/C4/C6 (separate PR).
Test plan
npm run typecheck && npm test(includes newcheck-greplica-home-pinandcheck-hook-worker-failures)Unit summary (commit
3f7d0d0)Dry-run transcripts
C3 — doctor + env pin
C2 — failed memory update leaves a trail
Made with Cursor