Desktop: Skip auto-updates for non-release builds - #412
Draft
priethor wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Non-release desktop builds no longer try to update themselves. They still check whether a newer release exists, but they do not use the download-and-install flow. "Check for Updates…" now explains that the app came from a branch and recommends installing a release. Tagged release builds keep the regular updater.
Why
Buildkite versions branch artifacts as
0.2.0-b6d0105.electron-updatertreats the SHA after the dash as a release channel, then reports "No published versions on GitHub" because that channel does not exist. A valid artifact ends up looking broken.Testing Instructions
I used Claude to help implement these changes. I guided the work, then tested and reviewed the result.