Obsidian sidebar - #3915
Open
LukeBenhase wants to merge 3 commits into
Open
Conversation
…king. open the sidebar with the command line in obsidian.
hippietrail
added
obsidian-plugin
Collaborator
|
Oooh! I like this a lot! I'm going to do a quick review of the code, compile this on my own machine, and come back with comments (if I have any). |
elijah-potter
requested changes
Jul 31, 2026
elijah-potter
left a comment
elijah-potter
left a comment
Collaborator
There was a problem hiding this comment.
This looks great! Definitely in the top 5% of PRs I receive. Thank you.
I have a few nits and bits, but once those are addressed, we can get this merged.
| return; | ||
| } | ||
|
|
||
| errors.forEach((error) => { |
Collaborator
There was a problem hiding this comment.
I think it would help readability to refactor this callback out into a separate function.
Collaborator
There was a problem hiding this comment.
By the way, I really like the UI you've designed.
Author
There was a problem hiding this comment.
Thanks. I'm not the most creative at UI design, so I tried to keep the style and colours of the pop-up that Harper uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
none
Description
I added a sidebar for Obsidian. The sidebar will show all of the improvements that Harper finds in the active page. You can open this sidebar with the command line in Obsidian under "Harper: Open Harper spellcheck sidebar". This will open the sidebar showing all of the errors. This sidebar was inspired by how Grammarly will allow the user to see all of their errors in a list, and it makes correcting errors much faster. The sidebar also brings in the 3 words before and after the mistake so that it is easier to see the correct word from the sidebar. A picture is below.
Demo
How Has This Been Tested?
I tested my changes on my Linux computer by compiling them into main.js and running it in Obsidian. It runs good and I have a screenshot above.
AI Disclosure
I am human and used AI outside of my editor and did not use any agents. I used Google Gemini to understand some parts of Obsidian.
If Your PR Implements or Enhances a Linter
I did not change the linter.
Checklist